Allow object downloads without authentication from certain remote object stores #14388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Ignored Deployments
|
sadhansood
changed the title
johnjmartin
approved these changes
Oct 25, 2023
williampsmith
approved these changes
Oct 25, 2023
sadhansood
force-pushed
the
sadhan/passwordless
branch
from
8b1f2a0 to
f59d47f
Compare
sadhansood
force-pushed
the
sadhan/passwordless
branch
from
f59d47f to
532d5fb
Compare
sadhansood
force-pushed
the
sadhan/passwordless
branch
from
532d5fb to
ae53bf9
Compare
sadhansood
force-pushed
the
sadhan/passwordless
branch
from
ae53bf9 to
860ff33
Compare
sadhansood
force-pushed
the
sadhan/passwordless
branch
from
860ff33 to
577255d
Compare
sadhansood
force-pushed
the
sadhan/passwordless
branch
from
577255d to
f229712
Compare
jonas-lj
pushed a commit
to jonas-lj/sui
that referenced
this pull request
Nov 2, 2023
…ect stores (MystenLabs#14388) ## Description We want to allow object download without authentication from certain remote stores with free egress i.e. cloudflare, wasabi, etc. This PR adds a new downloader module which allows us to do that for S3, GCS, etc Next step would be to integrate it in sui tool and let users benefit from it. ## Test Plan Added unit test. Also tested with S3 and found it to be working
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We want to allow object download without authentication from certain remote stores with free egress i.e. cloudflare, wasabi, etc. This PR adds a new downloader module which allows us to do that for S3, GCS, etc
Next step would be to integrate it in sui tool and let users benefit from it.
Test Plan
Added unit test. Also tested with S3 and found it to be working