Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cleanup] remove remaining logic for input object fastpath #14188

Merged
merged 2 commits into from
Oct 10, 2023

Conversation

mwtian
Copy link
Member

@mwtian mwtian commented Oct 10, 2023

Description

It seems this optimization is unlikely to come back, so removing the remaining scaffolding.

Test Plan

CI


If your changes are not user-facing and not a breaking change, you can skip the following section. Otherwise, please indicate what changed, and then add to the Release Notes section as highlighted during the release process.

Type of Change (Check all that apply)

  • protocol change
  • user-visible impact
  • breaking change for a client SDKs
  • breaking change for FNs (FN binary must upgrade)
  • breaking change for validators or node operators (must upgrade binaries)
  • breaking change for on-chain data layout
  • necessitate either a data wipe or data migration

Release notes

@vercel
Copy link

vercel bot commented Oct 10, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
mysten-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 10, 2023 7:01pm
sui-typescript-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 10, 2023 7:01pm
3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
explorer ⬜️ Ignored (Inspect) Visit Preview Oct 10, 2023 7:01pm
multisig-toolkit ⬜️ Ignored (Inspect) Visit Preview Oct 10, 2023 7:01pm
sui-kiosk ⬜️ Ignored (Inspect) Visit Preview Oct 10, 2023 7:01pm

Copy link
Contributor

@lxfind lxfind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool thanks!
Can you also delete _fullnode_fast_path_insert_objects_to_object_store_maybe from authorityty store?

@vercel vercel bot temporarily deployed to Preview – mysten-ui October 10, 2023 19:01 Inactive
@mwtian mwtian merged commit 9cb6af7 into MystenLabs:main Oct 10, 2023
31 checks passed
@mwtian mwtian deleted the cleanup-fastpath-input branch October 10, 2023 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants