Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade rust to 1.73.0 #14167

Merged
merged 18 commits into from
Oct 12, 2023
Merged

chore: upgrade rust to 1.73.0 #14167

merged 18 commits into from
Oct 12, 2023

Conversation

oxade
Copy link
Contributor

@oxade oxade commented Oct 8, 2023

Description

Main motivation is to pick up some new changes such as rust-lang/rust#115659
Most changes here are autogenerated by the new formatter
NFC

Test Plan

Existing


If your changes are not user-facing and not a breaking change, you can skip the following section. Otherwise, please indicate what changed, and then add to the Release Notes section as highlighted during the release process.

Type of Change (Check all that apply)

  • protocol change
  • user-visible impact
  • breaking change for a client SDKs
  • breaking change for FNs (FN binary must upgrade)
  • breaking change for validators or node operators (must upgrade binaries)
  • breaking change for on-chain data layout
  • necessitate either a data wipe or data migration

Release notes

@vercel
Copy link

vercel bot commented Oct 8, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sui-typescript-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 11, 2023 11:14pm
4 Ignored Deployments
Name Status Preview Comments Updated (UTC)
explorer ⬜️ Ignored (Inspect) Visit Preview Oct 11, 2023 11:14pm
multisig-toolkit ⬜️ Ignored (Inspect) Visit Preview Oct 11, 2023 11:14pm
mysten-ui ⬜️ Ignored (Inspect) Visit Preview Oct 11, 2023 11:14pm
sui-kiosk ⬜️ Ignored (Inspect) Visit Preview Oct 11, 2023 11:14pm

@bmwill
Copy link
Contributor

bmwill commented Oct 9, 2023

Before landing this we need to check to ensure this doesn't break reproducibility that @jnaulty has been working on.

@oxade oxade requested a review from jnaulty October 9, 2023 04:31
Copy link
Contributor

@bmwill bmwill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test

@oxade oxade merged commit 6cf5727 into main Oct 12, 2023
31 checks passed
@oxade oxade deleted the upgrade-rust branch October 12, 2023 03:50
oxade added a commit that referenced this pull request Oct 19, 2023
## Description 

Fixes some clippy lints ignored when
[this](#14167) PR was inteoduced.
Others coming shortly.

## Test Plan 

Existing

---
If your changes are not user-facing and not a breaking change, you can
skip the following section. Otherwise, please indicate what changed, and
then add to the Release Notes section as highlighted during the release
process.

### Type of Change (Check all that apply)

- [ ] protocol change
- [ ] user-visible impact
- [ ] breaking change for a client SDKs
- [ ] breaking change for FNs (FN binary must upgrade)
- [ ] breaking change for validators or node operators (must upgrade
binaries)
- [ ] breaking change for on-chain data layout
- [ ] necessitate either a data wipe or data migration

### Release notes
@oxade oxade mentioned this pull request Oct 20, 2023
7 tasks
oxade added a commit that referenced this pull request Oct 20, 2023
## Description 

This is the last cleanup for the outstanding lints from
#14167
In order to preserve existing behavior, it was easier to selectively
ignore the lints on specific files.

## Test Plan 

Existing
---
If your changes are not user-facing and not a breaking change, you can
skip the following section. Otherwise, please indicate what changed, and
then add to the Release Notes section as highlighted during the release
process.

### Type of Change (Check all that apply)

- [ ] protocol change
- [ ] user-visible impact
- [ ] breaking change for a client SDKs
- [ ] breaking change for FNs (FN binary must upgrade)
- [ ] breaking change for validators or node operators (must upgrade
binaries)
- [ ] breaking change for on-chain data layout
- [ ] necessitate either a data wipe or data migration

### Release notes
jonas-lj pushed a commit to jonas-lj/sui that referenced this pull request Nov 2, 2023
## Description 

Fixes some clippy lints ignored when
[this](MystenLabs#14167) PR was inteoduced.
Others coming shortly.

## Test Plan 

Existing

---
If your changes are not user-facing and not a breaking change, you can
skip the following section. Otherwise, please indicate what changed, and
then add to the Release Notes section as highlighted during the release
process.

### Type of Change (Check all that apply)

- [ ] protocol change
- [ ] user-visible impact
- [ ] breaking change for a client SDKs
- [ ] breaking change for FNs (FN binary must upgrade)
- [ ] breaking change for validators or node operators (must upgrade
binaries)
- [ ] breaking change for on-chain data layout
- [ ] necessitate either a data wipe or data migration

### Release notes
jonas-lj pushed a commit to jonas-lj/sui that referenced this pull request Nov 2, 2023
## Description 

This is the last cleanup for the outstanding lints from
MystenLabs#14167
In order to preserve existing behavior, it was easier to selectively
ignore the lints on specific files.

## Test Plan 

Existing
---
If your changes are not user-facing and not a breaking change, you can
skip the following section. Otherwise, please indicate what changed, and
then add to the Release Notes section as highlighted during the release
process.

### Type of Change (Check all that apply)

- [ ] protocol change
- [ ] user-visible impact
- [ ] breaking change for a client SDKs
- [ ] breaking change for FNs (FN binary must upgrade)
- [ ] breaking change for validators or node operators (must upgrade
binaries)
- [ ] breaking change for on-chain data layout
- [ ] necessitate either a data wipe or data migration

### Release notes
bmwill pushed a commit to move-language/move-sui that referenced this pull request Apr 18, 2024
## Description 

Fixes some clippy lints ignored when
[this](MystenLabs/sui#14167) PR was inteoduced.
Others coming shortly.

## Test Plan 

Existing

---
If your changes are not user-facing and not a breaking change, you can
skip the following section. Otherwise, please indicate what changed, and
then add to the Release Notes section as highlighted during the release
process.

### Type of Change (Check all that apply)

- [ ] protocol change
- [ ] user-visible impact
- [ ] breaking change for a client SDKs
- [ ] breaking change for FNs (FN binary must upgrade)
- [ ] breaking change for validators or node operators (must upgrade
binaries)
- [ ] breaking change for on-chain data layout
- [ ] necessitate either a data wipe or data migration

### Release notes
bmwill pushed a commit to move-language/move-sui that referenced this pull request Apr 18, 2024
## Description 

This is the last cleanup for the outstanding lints from
MystenLabs/sui#14167
In order to preserve existing behavior, it was easier to selectively
ignore the lints on specific files.

## Test Plan 

Existing
---
If your changes are not user-facing and not a breaking change, you can
skip the following section. Otherwise, please indicate what changed, and
then add to the Release Notes section as highlighted during the release
process.

### Type of Change (Check all that apply)

- [ ] protocol change
- [ ] user-visible impact
- [ ] breaking change for a client SDKs
- [ ] breaking change for FNs (FN binary must upgrade)
- [ ] breaking change for validators or node operators (must upgrade
binaries)
- [ ] breaking change for on-chain data layout
- [ ] necessitate either a data wipe or data migration

### Release notes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants