Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sim data source 1/x: parametize rest api data source #14164

Merged
merged 2 commits into from
Oct 8, 2023

Conversation

oxade
Copy link
Contributor

@oxade oxade commented Oct 8, 2023

Description

First part in a series of PRs to allow for simulated chain state which feeds into indexer etc and can be used for testing and experimentation

Test Plan

NFC


If your changes are not user-facing and not a breaking change, you can skip the following section. Otherwise, please indicate what changed, and then add to the Release Notes section as highlighted during the release process.

Type of Change (Check all that apply)

  • protocol change
  • user-visible impact
  • breaking change for a client SDKs
  • breaking change for FNs (FN binary must upgrade)
  • breaking change for validators or node operators (must upgrade binaries)
  • breaking change for on-chain data layout
  • necessitate either a data wipe or data migration

Release notes

@vercel
Copy link

vercel bot commented Oct 8, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
mysten-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 8, 2023 4:28am
sui-typescript-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 8, 2023 4:28am
3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
explorer ⬜️ Ignored (Inspect) Visit Preview Oct 8, 2023 4:28am
multisig-toolkit ⬜️ Ignored (Inspect) Oct 8, 2023 4:28am
sui-kiosk ⬜️ Ignored (Inspect) Oct 8, 2023 4:28am

@vercel vercel bot temporarily deployed to Preview – mysten-ui October 8, 2023 04:28 Inactive
@oxade oxade changed the title WIP: Sim parametize rest api data source WIP: sim data source: parametize rest api data source Oct 8, 2023
@oxade oxade changed the title WIP: sim data source: parametize rest api data source WIP: sim data source 1/x: parametize rest api data source Oct 8, 2023
@oxade oxade marked this pull request as ready for review October 8, 2023 18:20
@oxade oxade requested a review from gegaowp October 8, 2023 18:29
@oxade oxade changed the title WIP: sim data source 1/x: parametize rest api data source sim data source 1/x: parametize rest api data source Oct 8, 2023
@oxade oxade requested a review from wlmyng October 8, 2023 18:42
Copy link
Contributor

@wlmyng wlmyng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love it when you said NodeStateGetter and then NodeState got everywhere

@oxade oxade merged commit 2b29013 into main Oct 8, 2023
55 checks passed
@oxade oxade deleted the sim-parametize-rest-api-data-source branch October 8, 2023 20:53
oxade added a commit that referenced this pull request Oct 11, 2023
## Description 

Continuation of #14164
This will allow the simulator feed data into indexer etc

## Test Plan 

N/A

---
If your changes are not user-facing and not a breaking change, you can
skip the following section. Otherwise, please indicate what changed, and
then add to the Release Notes section as highlighted during the release
process.

### Type of Change (Check all that apply)

- [ ] protocol change
- [ ] user-visible impact
- [ ] breaking change for a client SDKs
- [ ] breaking change for FNs (FN binary must upgrade)
- [ ] breaking change for validators or node operators (must upgrade
binaries)
- [ ] breaking change for on-chain data layout
- [ ] necessitate either a data wipe or data migration

### Release notes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants