Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wallet-ext: approve dapp connection hide (de)select all when one account #14138

Merged
merged 1 commit into from
Oct 10, 2023

Conversation

pchrysochoidis
Copy link
Contributor

Description

before after
Screenshot 2023-10-06 at 12 34 39 Screenshot 2023-10-06 at 12 29 17
Screenshot 2023-10-06 at 12 33 55 Screenshot 2023-10-06 at 12 33 10

closes APPS-1808

Test Plan

How did you test the new or updated feature?


If your changes are not user-facing and not a breaking change, you can skip the following section. Otherwise, please indicate what changed, and then add to the Release Notes section as highlighted during the release process.

Type of Change (Check all that apply)

  • protocol change
  • user-visible impact
  • breaking change for a client SDKs
  • breaking change for FNs (FN binary must upgrade)
  • breaking change for validators or node operators (must upgrade binaries)
  • breaking change for on-chain data layout
  • necessitate either a data wipe or data migration

Release notes

@pchrysochoidis pchrysochoidis requested a review from a team as a code owner October 6, 2023 11:37
@pchrysochoidis pchrysochoidis requested review from Nikhil-Mysten and hayes-mysten and removed request for a team October 6, 2023 11:37
@vercel
Copy link

vercel bot commented Oct 6, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
mysten-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 9, 2023 0:00am
sui-typescript-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 9, 2023 0:00am
3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
explorer ⬜️ Ignored (Inspect) Visit Preview Oct 9, 2023 0:00am
multisig-toolkit ⬜️ Ignored (Inspect) Visit Preview Oct 9, 2023 0:00am
sui-kiosk ⬜️ Ignored (Inspect) Visit Preview Oct 9, 2023 0:00am

@pchrysochoidis pchrysochoidis merged commit c32ec6e into main Oct 10, 2023
34 checks passed
@pchrysochoidis pchrysochoidis deleted the pc-wallet-ext-apps-1808-approve-connection-fix branch October 10, 2023 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants