Clean up ConsensusHandler #14126
Merged
Clean up ConsensusHandler #14126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Ignored Deployments
|
lxfind
force-pushed
the
consensus-handler-restructure
branch
from
7a14652 to
ed1eedf
Compare
7 tasks
lxfind
force-pushed
the
consensus-handler-restructure
branch
from
ed1eedf to
5d816d7
Compare
lxfind
force-pushed
the
consensus-handler-restructure
branch
from
5d816d7 to
9b4175e
Compare
mwtian
approved these changes
Oct 10, 2023
|
|
||
| pub struct PostConsensusTxReorder {} | ||
|
|
||
| impl PostConsensusTxReorder { |
There was a problem hiding this comment.
TBH I'm not sure if it is worth it to pull this into a separate file. But either is fine.
| lock_and_final_round, | ||
|
|
||
| // The last block in this function notifies about new checkpoint if needed | ||
| let final_checkpoint_round = lock_and_final_round.map(|(_, r)| r); |
There was a problem hiding this comment.
What is the difference between this and the previous way of getting final_checkpoint_round?
There was a problem hiding this comment.
lock_and_final_round contains a lock besides the round
lxfind
force-pushed
the
consensus-handler-restructure
branch
from
9b4175e to
0a60588
Compare
lxfind
force-pushed
the
consensus-handler-restructure
branch
from
0a60588 to
04e5624
Compare
lxfind
force-pushed
the
consensus-handler-restructure
branch
from
04e5624 to
7ff723e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR does a few cleanups for ConsensusHandler:
Test Plan
CI
If your changes are not user-facing and not a breaking change, you can skip the following section. Otherwise, please indicate what changed, and then add to the Release Notes section as highlighted during the release process.
Type of Change (Check all that apply)
Release notes