OTLP tracing #14125
Merged
OTLP tracing #14125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mystenmark
requested review from
randall-Mysten and
ronny-mysten
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Ignored Deployments
|
mystenmark
requested review from
lxfind,
bmwill,
longbowlu and
mwtian
and removed request for
randall-Mysten and
ronny-mysten
bmwill
reviewed
Oct 6, 2023
Comment on lines
+96
to
+105
| struct EnableTracing { | ||
| filter: String, | ||
| duration: String, | ||
| } |
There was a problem hiding this comment.
Is there a way to disable it too?
There was a problem hiding this comment.
It disables automatically after the duration expires. I guess it wouldn't hurt to be able to disable it actively in case you set too long a duration by accident.
There was a problem hiding this comment.
added a disable route
| @@ -73,6 +71,8 @@ fn main() { | |||
| .with_prom_registry(&prometheus_registry) | |||
| .init(); | |||
|
|
|||
| drop(metrics_rt); | |||
|
|
|||
There was a problem hiding this comment.
Are these changes necessary?
There was a problem hiding this comment.
Yes - otherwise when we initialize TelemetryConfig, there is no active tokio runtime, so it can't install the batch exporter.
mystenmark
force-pushed
the
mlogan-tracing
branch
from
46d7e8f to
e1e7840
Compare
bmwill
approved these changes
Oct 7, 2023
mystenmark
force-pushed
the
mlogan-tracing
branch
from
e1e7840 to
c0cdfe9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables export of tracing span data via OTLP. Can be viewed with grafana/tempo:
Commits: