Redo Effects v2 protocol change #14085
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Ignored Deployments
|
lxfind
requested review from
longbowlu,
mystenmark,
bmwill,
oxade and
dariorussi
lxfind
force-pushed
the
effects-v2-protocol-change
branch
from
e40da17 to
6037ef5
Compare
mystenmark
approved these changes
Oct 5, 2023
lxfind
force-pushed
the
effects-v2-protocol-change
branch
from
d9b9e94 to
d40cbc2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a new feature flag in the protocol config to enable effects v2 (devnet only at the moment).
When effects v2 is enabled, the system will start emitting effects v2 type.
This is done inside TemporaryStore, where depending on the feature flag, we call different constructors of TransactionEffects.
The previous attempt did not properly gate this change under the feature flag, which is fixed by this PR (see the second commit in this PR).
In order to be compatible with effects v1 (under old protocol), we need to reconstruct all the different v1 fields.
These code can be cleaned up once we cut a new sui-execution version.
Test Plan
CI
If your changes are not user-facing and not a breaking change, you can skip the following section. Otherwise, please indicate what changed, and then add to the Release Notes section as highlighted during the release process.
Type of Change (Check all that apply)
Release notes