[move-compiler][sui-mode] Add init and one-time witness rules #13335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tnowacki
requested review from
amnn,
rvantonder,
cgswords,
awelc,
tzakian and
dariorussi
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
4 Ignored Deployments
|
awelc
approved these changes
Aug 16, 2023
| @@ -0,0 +1,12 @@ | |||
| warning[W09004]: unnecessary trailing semicolon | |||
There was a problem hiding this comment.
Nit. Since we seem to be testing bool field here, is the trailing semi warning really necessary here?
There was a problem hiding this comment.
Missed this, thanks!
|
|
||
| // Find the first invalid field in a one-time witness type, if any. | ||
| // First looks for a non-boolean field, otherwise looks for any field after the first. | ||
| fn invalid_otw_field_loc(fields: &Fields<Type>) -> Option<Loc> { |
There was a problem hiding this comment.
Nit. It took me a bit to parse it for correctness (which I think it is, and I am just slow...) but it probably wouldn't hurt adding a multi-field test.
7 tasks
- Added init and one-time witness rules to the compiler's sui mode
cgswords
reviewed
Aug 18, 2023
| true | ||
| }; | ||
| if valid_fields { | ||
| let name = mdef.structs.get_full_key_(&self.upper_module()).unwrap(); |
There was a problem hiding this comment.
Would it make sense to factor out this specific operation into a function or otherwise signpost that this is the way we find our OTW?
There was a problem hiding this comment.
Not sure I follow. What is it you want to break out into a separate function?
|
@cgswords, I'm going to land this since it is a rather large refactor. |
damirka
pushed a commit
that referenced
this pull request
Aug 22, 2023
## Description - Added init and one-time witness rules to the compiler's Sui mode ## Test Plan - Migrated tests --- If your changes are not user-facing and not a breaking change, you can skip the following section. Otherwise, please indicate what changed, and then add to the Release Notes section as highlighted during the release process. ### Type of Change (Check all that apply) - [ ] protocol change - [X] user-visible impact - [ ] breaking change for a client SDKs - [ ] breaking change for FNs (FN binary must upgrade) - [ ] breaking change for validators or node operators (must upgrade binaries) - [ ] breaking change for on-chain data layout - [ ] necessitate either a data wipe or data migration ### Release notes In this release, the Move compiler will now error on incorrect declarations (or usage) of `init` functions and one-time witnesses.
damirka
pushed a commit
that referenced
this pull request
Aug 23, 2023
## Description - Added init and one-time witness rules to the compiler's Sui mode ## Test Plan - Migrated tests --- If your changes are not user-facing and not a breaking change, you can skip the following section. Otherwise, please indicate what changed, and then add to the Release Notes section as highlighted during the release process. ### Type of Change (Check all that apply) - [ ] protocol change - [X] user-visible impact - [ ] breaking change for a client SDKs - [ ] breaking change for FNs (FN binary must upgrade) - [ ] breaking change for validators or node operators (must upgrade binaries) - [ ] breaking change for on-chain data layout - [ ] necessitate either a data wipe or data migration ### Release notes In this release, the Move compiler will now error on incorrect declarations (or usage) of `init` functions and one-time witnesses.
randall-Mysten
pushed a commit
that referenced
this pull request
Sep 6, 2023
## Description - Added init and one-time witness rules to the compiler's Sui mode ## Test Plan - Migrated tests --- If your changes are not user-facing and not a breaking change, you can skip the following section. Otherwise, please indicate what changed, and then add to the Release Notes section as highlighted during the release process. ### Type of Change (Check all that apply) - [ ] protocol change - [X] user-visible impact - [ ] breaking change for a client SDKs - [ ] breaking change for FNs (FN binary must upgrade) - [ ] breaking change for validators or node operators (must upgrade binaries) - [ ] breaking change for on-chain data layout - [ ] necessitate either a data wipe or data migration ### Release notes In this release, the Move compiler will now error on incorrect declarations (or usage) of `init` functions and one-time witnesses.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Test Plan
If your changes are not user-facing and not a breaking change, you can skip the following section. Otherwise, please indicate what changed, and then add to the Release Notes section as highlighted during the release process.
Type of Change (Check all that apply)
Release notes
In this release, the Move compiler will now error on incorrect declarations (or usage) of
initfunctions and one-time witnesses.