Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add license check for move, typescript, javascript files #1051

Merged
merged 3 commits into from
Mar 24, 2022
Merged

Add license check for move, typescript, javascript files #1051

merged 3 commits into from
Mar 24, 2022

Conversation

666lcz
Copy link
Contributor

@666lcz 666lcz commented Mar 23, 2022

These are the files output by find $TOPLEVEL -type d \( -path '$TOPLEVEL/target' -o -name 'node_modules' -o -name 'build' \) -prune -o \( -iname '*.rs' -o -iname '*.move' -o -iname '*.tsx' -o -iname '*.ts' -o -iname '*.js' \) -print

..//network_utils/src/unit_tests/transport_tests.rs
..//network_utils/src/transport.rs
..//network_utils/src/lib.rs
..//network_utils/src/network.rs
..//sui/tests/readme.rs
..//sui/src/shell.rs
..//sui/src/unit_tests/rest_server_tests.rs
..//sui/src/unit_tests/cli_tests.rs
..//sui/src/unit_tests/sui_json.rs
..//sui/src/unit_tests/data/custom_genesis_package_1/sources/CombinableObjects.move
..//sui/src/unit_tests/data/custom_genesis_package_1/sources/TicTacToe.move
..//sui/src/unit_tests/data/custom_genesis_package_1/sources/TrustedCoin.move
..//sui/src/unit_tests/data/custom_genesis_package_1/sources/CustomObjectTemplate.move
..//sui/src/unit_tests/data/custom_genesis_package_2/sources/M1.move
..//sui/src/unit_tests/data/dummy_modules_publish/sources/TrustedCoin.move
..//sui/src/unit_tests/shell_tests.rs
..//sui/src/config.rs
..//sui/src/lib.rs
..//sui/src/gateway.rs
..//sui/src/keystore.rs
..//sui/src/wallet.rs
..//sui/src/sui_json.rs
..//sui/src/sui_commands.rs
..//sui/src/sui-move.rs
..//sui/src/wallet_commands.rs
..//sui/src/sui.rs
..//sui/src/rest_server.rs
..//sui/src/bench.rs
..//test_utils/src/lib.rs
..//test_utils/src/sequencer.rs
..//nft_mirror/oracle_server/src/common/nftFetcher.ts
..//nft_mirror/oracle_server/src/sdk/gateway-generated-schema.ts
..//nft_mirror/oracle_server/src/sdk/index.ts
..//nft_mirror/oracle_server/src/sdk/gatewayServiceAPI.ts
..//nft_mirror/oracle_server/src/sdk/gateway.ts
..//nft_mirror/oracle_server/src/polyfills/fetch-polyfill.ts
..//nft_mirror/oracle_server/src/nfts/nftService.ts
..//nft_mirror/oracle_server/src/nfts/nftController.ts
..//nft_mirror/oracle_server/src/index.ts
..//nft_mirror/oracle_server/src/airdrop/airdropService.ts
..//nft_mirror/oracle_server/src/airdrop/airdropController.ts
..//explorer/client/tailwind.config.js
..//explorer/client/.eslintrc.js
..//explorer/client/src/index.tsx
..//explorer/client/src/app/App.tsx
..//explorer/client/src/utils/reportWebVitals.ts
..//explorer/client/src/setupTests.ts
..//explorer/client/src/components/footer/Footer.tsx
..//explorer/client/src/components/search/Search.tsx
..//explorer/client/src/components/external-link/ExternalLink.tsx
..//explorer/client/src/components/header/Header.tsx
..//explorer/client/src/__tests__/App.test.tsx
..//explorer/client/src/react-app-env.d.ts
..//explorer/client/src/pages/home/Home.tsx
..//explorer/client/src/pages/config/AppRoutes.tsx
..//explorer/client/src/pages/transaction-result/TransactionResult.test.tsx
..//explorer/client/src/pages/transaction-result/TransactionResult.tsx
..//explorer/client/src/pages/other-details/OtherDetails.tsx
..//sui_types/src/batch.rs
..//sui_types/src/unit_tests/serialize_tests.rs
..//sui_types/src/unit_tests/base_types_tests.rs
..//sui_types/src/unit_tests/messages_tests.rs
..//sui_types/src/id.rs
..//sui_types/src/error.rs
..//sui_types/src/gas_coin.rs
..//sui_types/src/gas.rs
..//sui_types/src/lib.rs
..//sui_types/src/object.rs
..//sui_types/src/serialize.rs
..//sui_types/src/event.rs
..//sui_types/src/committee.rs
..//sui_types/src/coin.rs
..//sui_types/src/storage.rs
..//sui_types/src/messages.rs
..//sui_types/src/base_types.rs
..//sui_types/src/move_package.rs
..//sui_types/src/crypto.rs
..//sui_programmability/tutorial/sources/M1.move
..//sui_programmability/framework/tests/BagTests.move
..//sui_programmability/framework/tests/TxContextTests.move
..//sui_programmability/framework/tests/CollectionTests.move
..//sui_programmability/framework/tests/TestScenarioTests.move
..//sui_programmability/framework/tests/UrlTests.move
..//sui_programmability/framework/tests/CrossChainAirdropTests.move
..//sui_programmability/framework/tests/IDTests.move
..//sui_programmability/framework/sources/Url.move
..//sui_programmability/framework/sources/Bag.move
..//sui_programmability/framework/sources/UTF8.move
..//sui_programmability/framework/sources/ERC721Metadata.move
..//sui_programmability/framework/sources/NFT.move
..//sui_programmability/framework/sources/CrossChainAirdrop.move
..//sui_programmability/framework/sources/ID.move
..//sui_programmability/framework/sources/Collection.move
..//sui_programmability/framework/sources/Coin.move
..//sui_programmability/framework/sources/ObjectBasics.move
..//sui_programmability/framework/sources/TxContext.move
..//sui_programmability/framework/sources/Math.move
..//sui_programmability/framework/sources/Geniteam.move
..//sui_programmability/framework/sources/TestScenario.move
..//sui_programmability/framework/sources/GAS.move
..//sui_programmability/framework/sources/Transfer.move
..//sui_programmability/framework/sources/Event.move
..//sui_programmability/framework/deps/move-stdlib/sources/BitVector.move
..//sui_programmability/framework/deps/move-stdlib/sources/BCS.move
..//sui_programmability/framework/deps/move-stdlib/sources/Hash.move
..//sui_programmability/framework/deps/move-stdlib/sources/Option.move
..//sui_programmability/framework/deps/move-stdlib/sources/ASCII.move
..//sui_programmability/framework/deps/move-stdlib/sources/Vector.move
..//sui_programmability/framework/deps/move-stdlib/sources/Errors.move
..//sui_programmability/framework/deps/move-stdlib/sources/GUID.move
..//sui_programmability/framework/deps/move-stdlib/sources/Signer.move
..//sui_programmability/framework/deps/move-stdlib/sources/Debug.move
..//sui_programmability/framework/deps/move-stdlib/sources/Capability.move
..//sui_programmability/framework/deps/move-stdlib/sources/UnitTest.move
..//sui_programmability/framework/deps/move-stdlib/sources/FixedPoint32.move
..//sui_programmability/framework/src/lib.rs
..//sui_programmability/framework/src/natives/id.rs
..//sui_programmability/framework/src/natives/event.rs
..//sui_programmability/framework/src/natives/test_scenario.rs
..//sui_programmability/framework/src/natives/mod.rs
..//sui_programmability/framework/src/natives/tx_context.rs
..//sui_programmability/framework/src/natives/transfer.rs
..//sui_programmability/adapter/src/bytecode_rewriter.rs
..//sui_programmability/adapter/src/adapter.rs
..//sui_programmability/adapter/src/unit_tests/adapter_tests.rs
..//sui_programmability/adapter/src/unit_tests/bytecode_rewriter_tests.rs
..//sui_programmability/adapter/src/unit_tests/data/call_ret/sources/M1.move
..//sui_programmability/adapter/src/unit_tests/data/publish_init/sources/M1.move
..//sui_programmability/adapter/src/unit_tests/data/publish_init_param/sources/M1.move
..//sui_programmability/adapter/src/unit_tests/data/simple_call/sources/M1.move
..//sui_programmability/adapter/src/unit_tests/data/publish_init_ret/sources/M1.move
..//sui_programmability/adapter/src/unit_tests/data/publish_init_public/sources/M1.move
..//sui_programmability/adapter/src/lib.rs
..//sui_programmability/adapter/src/genesis.rs
..//sui_programmability/examples/basics/sources/Sandwich.move
..//sui_programmability/examples/basics/sources/Object.move
..//sui_programmability/examples/basics/sources/Lock.move
..//sui_programmability/examples/nfts/tests/AuctionTests.move
..//sui_programmability/examples/nfts/tests/SharedAuctionTests.move
..//sui_programmability/examples/nfts/sources/SharedAuction.move
..//sui_programmability/examples/nfts/sources/Auction.move
..//sui_programmability/examples/nfts/sources/AuctionLib.move
..//sui_programmability/examples/nfts/sources/Geniteam.move
..//sui_programmability/examples/nfts/sources/Marketplace.move
..//sui_programmability/examples/nfts/sources/Num.move
..//sui_programmability/examples/fungible_tokens/sources/MANAGED.move
..//sui_programmability/examples/games/tests/SharedTicTacToeTests.move
..//sui_programmability/examples/games/tests/RockPaperScissorsTests.move
..//sui_programmability/examples/games/tests/TicTacToeTests.move
..//sui_programmability/examples/games/sources/RockPaperScissors.move
..//sui_programmability/examples/games/sources/TicTacToe.move
..//sui_programmability/examples/games/sources/SharedTicTacToe.move
..//sui_programmability/examples/games/hero/sources/SeaHeroHelper.move
..//sui_programmability/examples/games/hero/sources/Hero.move
..//sui_programmability/examples/games/hero/sources/SeaHero.move
..//sui_programmability/examples/defi/tests/FlashLenderTests.move
..//sui_programmability/examples/defi/sources/FlashLender.move
..//sui_programmability/examples/defi/sources/Escrow.move
..//sui_programmability/verifier/tests/struct_with_key_verification_test.rs
..//sui_programmability/verifier/tests/global_storage_access_verification_tests.rs
..//sui_programmability/verifier/tests/common/module_builder.rs
..//sui_programmability/verifier/tests/common/mod.rs
..//sui_programmability/verifier/tests/id_immutable_verification_test.rs
..//sui_programmability/verifier/tests/entry_function_param_verification.rs
..//sui_programmability/verifier/tests/id_leak_verification_test.rs
..//sui_programmability/verifier/src/id_immutable_verifier.rs
..//sui_programmability/verifier/src/id_leak_verifier.rs
..//sui_programmability/verifier/src/lib.rs
..//sui_programmability/verifier/src/global_storage_access_verifier.rs
..//sui_programmability/verifier/src/verifier.rs
..//sui_programmability/verifier/src/entry_function_param_verifier.rs
..//sui_programmability/verifier/src/struct_with_key_verifier.rs
..//sui_core/tests/format.rs
..//sui_core/src/consensus_handler.rs
..//sui_core/src/authority_aggregator.rs
..//sui_core/src/unit_tests/consensus_tests.rs
..//sui_core/src/unit_tests/client_tests.rs
..//sui_core/src/unit_tests/batch_transaction_tests.rs
..//sui_core/src/unit_tests/batch_tests.rs
..//sui_core/src/unit_tests/server_tests.rs
..//sui_core/src/unit_tests/authority_tests.rs
..//sui_core/src/unit_tests/move_integration_tests.rs
..//sui_core/src/unit_tests/data/object_wrapping/sources/ObjectWrapping.move
..//sui_core/src/unit_tests/data/hero/sources/Hero.move
..//sui_core/src/unit_tests/data/hero/sources/TrustedCoin.move
..//sui_core/src/unit_tests/data/object_owner/sources/ObjectOwner.move
..//sui_core/src/consensus_client.rs
..//sui_core/src/authority_batch.rs
..//sui_core/src/gateway_state/gateway_store.rs
..//sui_core/src/gateway_state/gateway_responses.rs
..//sui_core/src/lib.rs
..//sui_core/src/execution_engine.rs
..//sui_core/src/safe_client.rs
..//sui_core/src/generate_format.rs
..//sui_core/src/transaction_input_checker.rs
..//sui_core/src/authority_server.rs
..//sui_core/src/authority.rs
..//sui_core/src/authority/authority_store.rs
..//sui_core/src/authority/temporary_store.rs
..//sui_core/src/authority/authority_notifier.rs
..//sui_core/src/authority_client.rs
..//sui_core/src/gateway_state.rs

Testing

  1. check file output above contains rs, move ts, js, tsx files
  2. check the excluded directory does not appear in the result

@666lcz 666lcz requested a review from huitseeker March 23, 2022 19:10
@666lcz 666lcz linked an issue Mar 23, 2022 that may be closed by this pull request
Adapt the license checker to other types of files #1033
Closed
@666lcz 666lcz marked this pull request as ready for review March 23, 2022 19:11
@666lcz 666lcz requested review from lxfind and sblackshear March 23, 2022 20:34
huitseeker
huitseeker approved these changes Mar 24, 2022
View reviewed changes
Copy link
Contributor

@huitseeker huitseeker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much!
Nit: the shellcheck comment should be changed to

# shellcheck disable=SC2044,SC2086,SC2016

@666lcz 666lcz force-pushed the chris/license-check branch from ee86251 to b069b56 Compare March 24, 2022 22:03
@666lcz 666lcz merged commit 95ed0a6 into main Mar 24, 2022
@666lcz 666lcz deleted the chris/license-check branch March 24, 2022 22:41
@666lcz 666lcz mentioned this pull request Mar 25, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huitseeker huitseeker huitseeker approved these changes

@lxfind lxfind Awaiting requested review from lxfind

@sblackshear sblackshear Awaiting requested review from sblackshear

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Adapt the license checker to other types of files
2 participants
@666lcz @huitseeker