Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SuiJSON u128 support and extended docs #1011

Merged
merged 3 commits into from
Mar 22, 2022
Merged

Conversation

oxade
Copy link
Contributor

@oxade oxade commented Mar 22, 2022

Adds SuiJSON support for u128

Had to get rid of Serde::Value since it does not allows fixed size containers and u128
The changes here do not break existing REST server implementations

Next PR:
Enforce 0x prefix and address lengths in addresses and object ids in REST API. This is a breaking change.

@oxade oxade changed the title Add support for u128 and some documentation Add SuiJSON support for u128 and some documentation Mar 22, 2022
@oxade oxade changed the title Add SuiJSON support for u128 and some documentation Add SuiJSON u128 support and extended docs Mar 22, 2022
@oxade oxade assigned patrickkuo and unassigned patrickkuo Mar 22, 2022
@oxade oxade requested a review from patrickkuo March 22, 2022 13:05
Copy link
Contributor

@Clay-Mysten Clay-Mysten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Ade!

@oxade oxade merged commit d76c9ce into main Mar 22, 2022
@oxade oxade deleted the sui_json_u128_support branch March 22, 2022 15:30
@oxade oxade linked an issue Mar 23, 2022 that may be closed by this pull request
mwtian pushed a commit to mwtian/sui that referenced this pull request Sep 29, 2022
Bumps [tokio-stream](https://github.com/tokio-rs/tokio) from 0.1.9 to 0.1.10.
- [Release notes](https://github.com/tokio-rs/tokio/releases)
- [Commits](tokio-rs/tokio@tokio-stream-0.1.9...tokio-stream-0.1.10)

---
updated-dependencies:
- dependency-name: tokio-stream
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bcs serialization] Improve Serialization in SuiJson
3 participants