Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[move] Support U256 #618

Closed
666lcz opened this issue Mar 2, 2022 · 7 comments
Closed

[move] Support U256 #618

666lcz opened this issue Mar 2, 2022 · 7 comments
Assignees
@oxade
Labels
move Type: Enhancement New feature or request
Milestone
[G] Mainnet

Comments

@666lcz
Copy link
Contributor

666lcz commented Mar 2, 2022

Track the support for U256 per this comment
@666lcz 666lcz linked a pull request Mar 2, 2022 that will close this issue
[RFC] Add Starcoin-framework as a dependency #616
Closed
@666lcz 666lcz mentioned this issue Mar 4, 2022
Merged
@oxade
Copy link
Contributor

oxade commented Mar 4, 2022 •
edited
Loading

We will also need to provide u128 and u256 support in SuiJSON so that external apps can utilize the full Move types.
Related to https://github.com/MystenLabs/fastnft/blob/main/sui/src/sui_json.rs#L119

We're considering encoding large integers as strings or creating a custom BigInt object
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/BigInt

@666lcz 666lcz added this to the Pre Testnet milestone Apr 19, 2022
@gdanezis gdanezis added the Type: Enhancement New feature or request label Jun 17, 2022
@gdanezis gdanezis modified the milestones: Pre Testnet, Mainnet Jun 17, 2022
@gdanezis gdanezis added the move label Jun 17, 2022
@bholc646
Copy link
Contributor

Do we still have work to do here, or is Aptos and other peeps in the community doing all of this work? @sblackshear @tnowacki

@tnowacki
Copy link
Contributor

We have not heard anything from the Move contributor side of things in a while, so not sure

mwtian pushed a commit that referenced this issue Sep 12, 2022
@joyqvq
crypto: use result instead of unwrap when parsing (#618)
042d7e1
mwtian pushed a commit to mwtian/sui that referenced this issue Sep 29, 2022
@joyqvq
crypto: use result instead of unwrap when parsing (MystenLabs#618)
3d59d57
@at5500
Copy link

at5500 commented Oct 29, 2022

Hi! Move merged u256 support: move-language/move#547

@oxade oxade self-assigned this Oct 29, 2022
@oxade
Copy link
Contributor

oxade commented Oct 29, 2022

Hi! Move merged u256 support: move-language/move#547

Yes, we're aware. Support in Sui is coming soon.
See the PR: #5659

@oxade
Copy link
Contributor

oxade commented Oct 30, 2022

Most of the support will come in this PR
#5659

@oxade
Copy link
Contributor

oxade commented Oct 31, 2022

This is merged in Sui now.

@oxade oxade closed this as completed Oct 31, 2022
This was referenced Nov 10, 2022
Open
Open
This was referenced Nov 19, 2022
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oxade oxade

Labels
move Type: Enhancement New feature or request
Projects
None yet
Milestone
[G] Mainnet
Development

Successfully merging a pull request may close this issue.

[RFC] Add Starcoin-framework as a dependency MystenLabs/sui
6 participants
@tnowacki @gdanezis @at5500 @666lcz @oxade @bholc646