Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wallet CLI] Object not listed with new owner after transfer #603

Closed
awelc opened this issue Mar 1, 2022 · 6 comments
Closed

[wallet CLI] Object not listed with new owner after transfer #603

awelc opened this issue Mar 1, 2022 · 6 comments

Comments

@awelc
Copy link
Contributor

awelc commented Mar 1, 2022

As you can see below, object F18F5B785D5766CD85BC2247F8C73F07BFF901BB shows a new owner when queried but does not show up on the new owner's list of objects.

sui>-$ addresses
Showing 5 results.
0DC70EA8CA82FE6966900C697B73A235B8E2346F
3111A757BE55F195201FD9140DCE55EAEB719D35
4E523C1FAFECE13628161C78521E60AA8B602324
D9573E0B7F73B15C4416DCBD9911CC1A9456CF21
FE574F043D282AAF10B9AE8AB337C74BA8B428C3

sui>-$ objects --address 0DC70EA8CA82FE6966900C697B73A235B8E2346F
Showing 5 results.
(60DADCE6E5081C3EFCA162694D7EFD8D99D46636, SequenceNumber(0), o#233a8dc055be8641a95ddf5ce6cd50ed92eb6e08d3ae34c581ac801e61062e95)
(B216DCFE027479D0BE9D85A5CD7184E9673452D8, SequenceNumber(0), o#fb49986cfbbb81b49c04759a7d6421186e800e653f9394ee3c5c813d88ab70f1)
(B56269D5C471367BEDEDDFCBE8A9D928E7C1F170, SequenceNumber(0), o#ec469726275e1bff12a75288b00dc3e4b5bc2d4c98b96e05ae3cb1b71752cdb3)
(D9DBDEDB501C63996E2662DDD23A76A642E8160B, SequenceNumber(0), o#a12c1948efd5331d6e852163fbd78a598e368cab0c78dd240d268c0de4dcc211)
(F18F5B785D5766CD85BC2247F8C73F07BFF901BB, SequenceNumber(0), o#54d934be002b7c38d47a6586a17c839beefd227e0b2c1fb00eadff131b38acbb)
sui>-$ call --function transfer --module GAS --package 0x2 --args "0xF18F5B785D5766CD85BC2247F8C73F07BFF901BB" "0x3111A757BE55F195201FD9140DCE55EAEB719D35" --gas 60DADCE6E5081C3EFCA162694D7EFD8D99D46636 --gas-budget 1000

sui>-$ object --id F18F5B785D5766CD85BC2247F8C73F07BFF901BB
Owner: SingleOwner(k#3111a757be55f195201fd9140dce55eaeb719d35)
Version: 1
ID: F18F5B785D5766CD85BC2247F8C73F07BFF901BB
Readonly: false
Type: 0x2::Coin::Coin<0x2::GAS::GAS>

sui>-$ objects --address 3111A757BE55F195201FD9140DCE55EAEB719D35
Showing 5 results.
(55D1E751611846F532B25A0A2DBBAF89B6DF3D3A, SequenceNumber(0), o#7c1a0b37c869298e81b9de5e0d29d2dd3f51442cd820a13f7cf56f76b685f02f)
(7EC360942939EAF89DFE63EF31B855D2474077BB, SequenceNumber(0), o#845bc0491ed536fe45c810082224c9d76164699f9253edf8275b4fd73c6ff77f)
(CEAEFF892F08F34222C7437167E696B6D8DF33DB, SequenceNumber(0), o#b27749ce87293851635f71418d620b340f291c74f0058f90771e80ee529ff3c4)
(F90B1AECB2AB14D34A404AB7DB0A9EF94CE76312, SequenceNumber(0), o#ec8b0d2cdf68a25e8b85062db22d926d9cff83fb9785e74bf551308cec8babc1)
(FB5F24A3A588530D690CD0286C81897925ACF17B, SequenceNumber(0), o#126c241738c855eb137bcce7bc5378089aa8f9f597c6324a6f794a0edefc4337)
@awelc awelc added this to the Private SDK Release milestone Mar 1, 2022
@oxade
Copy link
Contributor

oxade commented Mar 1, 2022

@awelc did you call sync?

@awelc
Copy link
Contributor Author

awelc commented Mar 1, 2022

@awelc did you call sync?

I did not as when I was writing the docs originally it wasn't needed. I will retest and report back!

@lxfind
Copy link
Contributor

lxfind commented Mar 1, 2022

This is sort of expected (but also should be considered as a bug).
Basically we need to fill in this TODO: https://github.com/MystenLabs/fastnft/blob/main/sui_core/src/client.rs#L562
Should be a simple one now that we have finished migrating the API to AddressManager.

@patrickkuo
Copy link
Contributor

this PR fixes this temporally until we implement shared storage in AccountManager #569

@lxfind
Copy link
Contributor

lxfind commented Mar 1, 2022

Note that this doesn't require shared storage. Shared storage is only required to be able to store immutable or shared objects.
For transferred objects, all we need to do is to put it in the corresponding account.

@bholc646 bholc646 removed this from the Private SDK Release milestone Apr 6, 2022
@awelc
Copy link
Contributor Author

awelc commented Apr 7, 2022

Calling sync is the solution even if auto-sync does not work (which it should now, at least for this example) so closing this issue.

@awelc awelc closed this as completed Apr 7, 2022
mwtian pushed a commit that referenced this issue Sep 12, 2022
* Replace consensus number notification Atomic with async watch

* Rename & review comments

* fmt

* Change names + header gc

Co-authored-by: George Danezis <[email protected]>
mwtian pushed a commit to mwtian/sui that referenced this issue Sep 29, 2022
…Labs#603)

* Replace consensus number notification Atomic with async watch

* Rename & review comments

* fmt

* Change names + header gc

Co-authored-by: George Danezis <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants