Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't run rust tests when only docs change #1005

Closed
todd-mystenlabs opened this issue Mar 21, 2022 · 3 comments
Closed

Don't run rust tests when only docs change #1005

todd-mystenlabs opened this issue Mar 21, 2022 · 3 comments

Comments

@todd-mystenlabs
Copy link
Contributor

I'm not sure if there are cases where this would be wrong, but it would be great to avoid running tests when we're just changing dev portal and root-dir files like CONTRIBUTING.md, ISSUES.md, etc.

Right now I'm waiting 15+ minutes for the test suite to run on content that changes CONTRIBUTING.md.
@gdanezis
Copy link
Collaborator

More over I am not sure if we can skip the review process for doc only / .md files. I am not sure if the usual process we do for code is the best for fixing text.

@todd-mystenlabs
Copy link
Contributor Author

@bmwill - did you say you addressed this? We can close it out if so.

@gdanezis
Copy link
Collaborator

Done!

mwtian pushed a commit to mwtian/sui that referenced this issue Sep 29, 2022
@akichidis
[subscriber] convert to sequential approach (MystenLabs#1005)
cbd8ab6 
This commit converts the Subscriber to blocking execution. Refactored the recovery method.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@gdanezis @todd-mystenlabs @bholc646