Remove deprecated APIs (#14152)

## Description 

Describe the changes or additions included in this PR.

## Test Plan 

How did you test the new or updated feature?

---
If your changes are not user-facing and not a breaking change, you can
skip the following section. Otherwise, please indicate what changed, and
then add to the Release Notes section as highlighted during the release
process.

### Type of Change (Check all that apply)

- [ ] protocol change
- [ ] user-visible impact
- [ ] breaking change for a client SDKs
- [ ] breaking change for FNs (FN binary must upgrade)
- [ ] breaking change for validators or node operators (must upgrade
binaries)
- [ ] breaking change for on-chain data layout
- [ ] necessitate either a data wipe or data migration

### Release notes

.changeset/nasty-weeks-clap.md

@@ -0,0 +1,6 @@
+---
+'@mysten/wallet-kit': minor
+'@mysten/sui.js': minor
+---
+
+Remove deprecated methods.

apps/wallet/src/background/accounts/Account.ts

@@ -80,7 +80,7 @@ export abstract class Account<
 		return toSerializedSignature({
 			signature,
 			signatureScheme,
-			pubKey: pubkey,
+			publicKey: pubkey,
 		});
 	}
 

apps/wallet/src/background/keyring/AccountKeypair.ts

@@ -26,7 +26,7 @@ export class AccountKeypair {
 		return toSerializedSignature({
 			signature,
 			signatureScheme,
-			pubKey: pubkey,
+			publicKey: pubkey,
 		});
 	}
 

apps/wallet/src/ui/app/LedgerSigner.ts

@@ -54,11 +54,11 @@ export class LedgerSigner extends WalletSigner {
 	async signData(data: Uint8Array): Promise<SerializedSignature> {
 		const ledgerClient = await this.#initializeSuiLedgerClient();
 		const { signature } = await ledgerClient.signTransaction(this.#derivationPath, data);
-		const pubKey = await this.getPublicKey();
+		const publicKey = await this.getPublicKey();
 		return toSerializedSignature({
 			signature,
 			signatureScheme: this.#signatureScheme,
-			pubKey,
+			publicKey,
 		});
 	}
 

sdk/move-binary-format-wasm/package.json

@@ -15,6 +15,7 @@
   "devDependencies": {
     "tsup": "^7.1.0",
     "typescript": "^5.1.6",
-    "vitest": "^0.33.0"
+    "vitest": "^0.33.0",
+    "wasm-pack": "^0.12.1"
   }
 }

sdk/typescript/src/builder/TransactionBlock.ts

@@ -9,7 +9,6 @@ import { bcs } from '../bcs/index.js';
 import type { ProtocolConfig, SuiClient, SuiMoveNormalizedType } from '../client/index.js';
 import type { Keypair, SignatureWithBytes } from '../cryptography/index.js';
 import { SUI_TYPE_ARG } from '../framework/framework.js';
-import type { JsonRpcProvider } from '../providers/json-rpc-provider.js';
 import type { SuiObjectResponse } from '../types/index.js';
 import {
 	extractMutableReference,
@@ -96,13 +95,13 @@ function createTransactionResult(index: number): TransactionResult {
 }
 
 function expectClient(options: BuildOptions): SuiClient {
-	if (!options.client && !options.provider) {
+	if (!options.client) {
 		throw new Error(
 			`No provider passed to Transaction#build, but transaction data was not sufficient to build offline.`,
 		);
 	}
 
-	return (options.client ?? options.provider!) as SuiClient;
+	return options.client;
 }
 
 const TRANSACTION_BRAND = Symbol.for('@mysten/transaction');
@@ -132,11 +131,7 @@ const chunk = <T>(arr: T[], size: number): T[][] =>
 	);
 
 interface BuildOptions {
-	/**
-	 * @deprecated Use `client` instead.
-	 */
-	provider?: JsonRpcProvider | SuiClient;
-	client?: SuiClient | JsonRpcProvider;
+	client?: SuiClient;
 	onlyTransactionKind?: boolean;
 	/** Define a protocol config to build against, instead of having it fetched from the provider at build time. */
 	protocolConfig?: ProtocolConfig;
@@ -156,13 +151,6 @@ export function isTransactionBlock(obj: unknown): obj is TransactionBlock {
  * Transaction Builder
  */
 export class TransactionBlock {
-	/** Returns `true` if the object is an instance of the Transaction builder class.
-	 * @deprecated Use `isTransactionBlock` from `@mysten/sui.js/transactions` instead.
-	 */
-	static is(obj: unknown): obj is TransactionBlock {
-		return !!obj && typeof obj === 'object' && (obj as any)[TRANSACTION_BRAND] === true;
-	}
-
 	/**
 	 * Converts from a serialize transaction kind (built with `build({ onlyTransactionKind: true })`) to a `Transaction` class.
 	 * Supports either a byte array, or base64-encoded bytes.
@@ -198,22 +186,6 @@ export class TransactionBlock {
 		return tx;
 	}
 
-	/**
-	 * A helper to retrieve the Transaction builder `Transactions`
-	 * @deprecated Either use the helper methods on the `TransactionBlock` class, or import `Transactions` from `@mysten/sui.js/transactions`.
-	 */
-	static get Transactions() {
-		return Transactions;
-	}
-
-	/**
-	 * A helper to retrieve the Transaction builder `Inputs`
-	 * * @deprecated Either use the helper methods on the `TransactionBlock` class, or import `Inputs` from `@mysten/sui.js/transactions`.
-	 */
-	static get Inputs() {
-		return Inputs;
-	}
-
 	setSender(sender: string) {
 		this.#blockData.sender = sender;
 	}
@@ -526,10 +498,6 @@ export class TransactionBlock {
 	/** Derive transaction digest */
 	async getDigest(
 		options: {
-			/**
-			 * @deprecated Use `client` instead.
-			 */
-			provider?: JsonRpcProvider | SuiClient;
 			client?: SuiClient;
 		} = {},
 	): Promise<string> {
@@ -806,10 +774,8 @@ export class TransactionBlock {
 			throw new Error('Missing transaction sender');
 		}
 
-		const client = options.client || options.provider;
-
-		if (!options.protocolConfig && !options.limits && client) {
-			options.protocolConfig = await client.getProtocolConfig();
+		if (!options.protocolConfig && !options.limits && options.client) {
+			options.protocolConfig = await options.client.getProtocolConfig();
 		}
 
 		await Promise.all([this.#prepareGasPrice(options), this.#prepareTransactions(options)]);

sdk/typescript/src/cryptography/keypair.ts

@@ -40,7 +40,7 @@ export abstract class BaseSigner {
 		const signature = toSerializedSignature({
 			signature: await this.sign(digest),
 			signatureScheme: this.getKeyScheme(),
-			pubKey: this.getPublicKey(),
+			publicKey: this.getPublicKey(),
 		});
 
 		return {
@@ -64,13 +64,6 @@ export abstract class BaseSigner {
 		);
 	}
 
-	/**
-	 * @deprecated use `signPersonalMessage` instead
-	 */
-	async signMessage(bytes: Uint8Array) {
-		return this.signPersonalMessage(bytes);
-	}
-
 	toSuiAddress(): string {
 		return this.getPublicKey().toSuiAddress();
 	}

sdk/typescript/src/cryptography/multisig.ts

@@ -189,7 +189,7 @@ export function decodeMultiSig(signature: string): SignaturePubkeyPair[] {
 }
 
 function toPkWeightPair(pair: PubkeyWeightPair): PubkeyEnumWeightPair {
-	let pk_bytes = Array.from(pair.pubKey.toBytes().map((x) => Number(x)));
+	let pk_bytes = Array.from(pair.pubKey.toRawBytes().map((x) => Number(x)));
 	switch (pair.pubKey.flag()) {
 		case SIGNATURE_SCHEME_TO_FLAG['Secp256k1']:
 			return {

sdk/typescript/src/cryptography/publickey.ts

@@ -48,13 +48,10 @@ export abstract class PublicKey {
 		return toB64(this.toRawBytes());
 	}
 
-	/**
-	 * @deprecated use toBase64 instead.
-	 *
-	 * Return the base-64 representation of the public key
-	 */
-	toString() {
-		return this.toBase64();
+	toString(): never {
+		throw new Error(
+			'`toString` is not implemented on public keys. Use `toBase64()` or `toRawBytes()` instead.',
+		);
 	}
 
 	/**
@@ -115,13 +112,6 @@ export abstract class PublicKey {
 		return suiBytes;
 	}
 
-	/**
-	 * @deprecated use `toRawBytes` instead.
-	 */
-	toBytes() {
-		return this.toRawBytes();
-	}
-
 	/**
 	 * Return the Sui address associated with this Ed25519 public key
 	 */

sdk/typescript/src/cryptography/signature.ts

@@ -23,8 +23,6 @@ export type SerializeSignatureInput = {
 	signatureScheme: SignatureScheme;
 	/** Base64-encoded signature */
 	signature: Uint8Array;
-	/** @deprecated use publicKey instead */
-	pubKey?: PublicKey;
 	/** Base64-encoded public key */
 	publicKey?: PublicKey;
 };
@@ -41,14 +39,13 @@ export type SerializedSignature = string;
 export function toSerializedSignature({
 	signature,
 	signatureScheme,
-	pubKey,
-	publicKey = pubKey,
+	publicKey,
 }: SerializeSignatureInput): SerializedSignature {
 	if (!publicKey) {
 		throw new Error('`publicKey` is required');
 	}
 
-	const pubKeyBytes = publicKey.toBytes();
+	const pubKeyBytes = publicKey.toRawBytes();
 	const serializedSignature = new Uint8Array(1 + signature.length + pubKeyBytes.length);
 	serializedSignature.set([SIGNATURE_SCHEME_TO_FLAG[signatureScheme]]);
 	serializedSignature.set(signature, 1);

sdk/typescript/src/framework/framework.ts

@@ -5,7 +5,7 @@ import type { Infer } from 'superstruct';
 import { nullable, number, object, string } from 'superstruct';
 
 import type { StructTag } from '../bcs/index.js';
-import type { CoinStruct } from '../types/coin.js';
+import type { CoinStruct } from '../client/types/index.js';
 import type {
 	SuiMoveObject,
 	SuiObjectData,

sdk/typescript/src/framework/sui-system-state.ts

@@ -3,7 +3,6 @@
 
 import { TransactionBlock } from '../builder/index.js';
 import type { SuiClient } from '../client/index.js';
-import type { JsonRpcProvider } from '../providers/json-rpc-provider.js';
 import { getObjectReference } from '../types/index.js';
 import { normalizeSuiObjectId } from '../utils/sui-types.js';
 import { SUI_SYSTEM_ADDRESS } from './framework.js';
@@ -31,7 +30,7 @@ export class SuiSystemStateUtil {
 	 * @param gasBudget omittable only for DevInspect mode
 	 */
 	public static async newRequestAddStakeTxn(
-		client: JsonRpcProvider | SuiClient,
+		client: SuiClient,
 		coins: string[],
 		amount: bigint,
 		validatorAddress: string,