Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: improve test coverage #9

Merged
merged 2 commits into from
Sep 27, 2023
Merged

test: improve test coverage #9

merged 2 commits into from
Sep 27, 2023

Conversation

mlegner
Copy link
Contributor

@mlegner mlegner commented Sep 25, 2023

Follow-up on #6 and #7.

@mlegner mlegner added the rust label Sep 25, 2023
@mlegner mlegner requested a review from jpcsmith as a code owner September 25, 2023 12:48
@mlegner mlegner changed the title tests: improve test coverage test: improve test coverage Sep 25, 2023
@mlegner mlegner enabled auto-merge (rebase) September 25, 2023 12:49
@github-actions
Copy link
Contributor

Code Coverage

Package Line Rate Health
crates/scion/src 100% ✔
crates/scion/src/address 100% ✔
Summary 100% (103 / 103) ✔

jpcsmith
jpcsmith approved these changes Sep 27, 2023
View reviewed changes
Copy link
Contributor

@jpcsmith jpcsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the additional tests.

Remark: Going forward I think it would be good to discuss our expectations for test coverage.

@mlegner mlegner merged commit 5daa4ca into main Sep 27, 2023
9 checks passed
@mlegner mlegner deleted the tests/unit-tests branch September 27, 2023 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpcsmith jpcsmith jpcsmith approved these changes

Assignees
No one assigned
Labels
rust
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mlegner @jpcsmith