Skip to content
This repository has been archived by the owner on Sep 8, 2024. It is now read-only.

Issues 54 - Pairing code is not displayed when device is unpaired #78

Closed
wants to merge 7 commits into from

Conversation

jdorleans
Copy link
Contributor

@jdorleans jdorleans commented Jun 1, 2016

Issue description: #54

Test Cases:

  1. Unit is not paired and user interact with Mycroft for the first time after starting the services
    • Device must display the pairing code after any user query, except when user says "Mycroft" only. In that case, we'll have a "Go ahead" feedback
  2. Unit is not paired and user interact with Mycroft for the second time and on
    • Device must keep the pairing code displayed preventing any other mouth animation
  3. Unit is already paired
    • No pairing code must be shown and device perform any other action as expected

@jdorleans jdorleans changed the title Issues #54 Issues 54 - Pairing code is not displayed when device is unpaired Jun 1, 2016
@ryanleesipes
Copy link

@isaacnward please test this branch, @ethanaward please provide him assistance if he needs help getting set up on the device.

@isaacnward
Copy link
Contributor

The pairing code message displays on this branch, but it displays very slowly. Would it be more helpful if the unit only displayed the code itself on its mouth, without the "PAIRING CODE:" section?

@ryanleesipes
Copy link

I second @isaacnward's feedback. @aatchison can you test this on your device and confirm the slow scrolling?

@jdorleans jdorleans self-assigned this Jun 2, 2016
jdorleans and others added 7 commits June 2, 2016 15:37
- Ensuring pairing code is displayed after mycroft speaks
 - Ensuring pairing code is sent to the device after speaking
 - Ensuring Enclosure do not affect unit display state until paired
 - Ensuring displaying state is reset
@jdorleans
Copy link
Contributor Author

Ok, I've removed "Pairing code" from the text. However, keep in mind, increasing the text scroll speed is outside the scope of this task. If we want to change that, we have to create a task for the enclose project.

@ryanleesipes
Copy link

Can we make it not scroll at all?

On Thu, Jun 2, 2016, 2:59 PM jdorleans [email protected] wrote:

Ok, I've removed "Pairing code" from the text. However, keep in mind,
increasing the text scroll speed is outside the scope of this task. If we
want to change that, we have to create a task for the enclose project.


You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
#78 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/ACCtteW6e-w8EzqjR1ZP4ZBXkq6QFrcxks5qHzYZgaJpZM4Ir5Qj
.

Ryan Sipes
CTO, Mycroft A.I.
https://mycroft.ai
785-979-6091

@jdorleans
Copy link
Contributor Author

We can create a new functionality on the enclosure to opt to either scroll the text or not. However, it can cause undesirable behaviour if someone sends a text bigger than the display. Maybe, in that case we can enforce the scroll. Anyway, that's all about new features on the enclosure. Let's focus on this PR scope and finish it.

@ryanleesipes
Copy link

Alright, works, LGTM, merge.

@jdorleans jdorleans closed this Jun 2, 2016
@jdorleans jdorleans deleted the bugfix/issues-54 branch June 2, 2016 23:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants