-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Issues 54 - Pairing code is not displayed when device is unpaired #78
Conversation
@isaacnward please test this branch, @ethanaward please provide him assistance if he needs help getting set up on the device. |
The pairing code message displays on this branch, but it displays very slowly. Would it be more helpful if the unit only displayed the code itself on its mouth, without the "PAIRING CODE:" section? |
I second @isaacnward's feedback. @aatchison can you test this on your device and confirm the slow scrolling? |
- Ensuring pairing code is displayed after mycroft speaks
- Ensuring pairing code is sent to the device after speaking
- Ensuring Enclosure do not affect unit display state until paired
- Ensuring displaying state is reset
855d74b
to
65fb298
Compare
Ok, I've removed "Pairing code" from the text. However, keep in mind, increasing the text scroll speed is outside the scope of this task. If we want to change that, we have to create a task for the enclose project. |
Can we make it not scroll at all? On Thu, Jun 2, 2016, 2:59 PM jdorleans [email protected] wrote:
|
We can create a new functionality on the enclosure to opt to either scroll the text or not. However, it can cause undesirable behaviour if someone sends a text bigger than the display. Maybe, in that case we can enforce the scroll. Anyway, that's all about new features on the enclosure. Let's focus on this PR scope and finish it. |
Alright, works, LGTM, merge. |
Issue description: #54
Test Cases: