This repository has been archived by the owner on Sep 8, 2024. It is now read-only.
get response tests #2838
Merged
get response tests #2838
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devops-mycroft
added
the
CLA: Yes
|
Voight Kampff Integration Test Succeeded (Results) |
- get_response - ask_yesno - ask_selection
Fix off by one issue preventing the last option to be selected by number.
forslund
force-pushed
the
test/get_response-tests
branch
from
d513e8d to
3a6ca30
Compare
|
Voight Kampff Integration Test Succeeded (Results) |
krisgesling
approved these changes
Mar 10, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add some basic tests for the
get_response(),ask_selection()and theask_yesno()methods of theMycroftSkill.This also fixes an off-by-one issue found in the
ask_selection()when writing the test cases.How to test
Ensure that the unittests passes.
Contributor license agreement signed?
CLA [ Yes ]