This repository has been archived by the owner on Sep 8, 2024. It is now read-only.
Reorder operations to ensure removed Skills are first unloaded. #2823
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prevents SkillManager from attempting to reload a Skill that has just been removed from the system which results in a FileNotFoundError Fixes #2822
krisgesling
added
the
Type: Bug - quick
devops-mycroft
added
the
CLA: Yes
|
Voight Kampff Integration Test Succeeded (Results) |
|
Looks good, can't think of a reason this should cause issues. Should only be better! :) |
forslund
approved these changes
Feb 4, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevents SkillManager from attempting to reload a Skill that has just been removed from the system which results in a
FileNotFoundErrorFixes #2822
How to test
Run Skills unit tests and ensure nothing has broken.
Contributor license agreement signed?