Skip to content
This repository has been archived by the owner on Sep 8, 2024. It is now read-only.

revert a temporary bugfix from PR #2626 #2741

Merged
merged 1 commit into from
Jun 7, 2021
Merged

Conversation

krisgesling
Copy link
Contributor

Description

Reverts changes from PR #2626 removing the 10 second sleep after Skills have loaded.

How to test

See if previous VK failures start to re-appear.

Contributor license agreement signed?

@krisgesling krisgesling added the Status: Work in progress PR being actively worked on, not yet ready for review. label Oct 28, 2020
@devs-mycroft devs-mycroft added the CLA: Yes Contributor License Agreement exists (see https://github.com/MycroftAI/contributors) label Oct 28, 2020
@devops-mycroft
Copy link

Voight Kampff Integration Test Succeeded (Results)

4 similar comments
@devops-mycroft
Copy link

Voight Kampff Integration Test Succeeded (Results)

@devops-mycroft
Copy link

Voight Kampff Integration Test Succeeded (Results)

@devops-mycroft
Copy link

Voight Kampff Integration Test Succeeded (Results)

@devops-mycroft
Copy link

Voight Kampff Integration Test Succeeded (Results)

@devops-mycroft
Copy link

Voight Kampff Integration Test Failed (Results).
Mycroft logs are also available: skills.log, audio.log, voice.log, bus.log, enclosure.log

@devops-mycroft
Copy link

Voight Kampff Integration Test Failed (Results)

@krisgesling krisgesling reopened this Jan 29, 2021
@devops-mycroft
Copy link

Voight Kampff Integration Test Failed (Results).
Mycroft logs are also available: skills.log, audio.log, voice.log, bus.log, enclosure.log

@krisgesling krisgesling reopened this Jan 29, 2021
@devops-mycroft
Copy link

Voight Kampff Integration Test Succeeded (Results)

@krisgesling krisgesling added Status: To be reviewed Concept accepted and PR has sufficient information for full review and removed Status: Work in progress PR being actively worked on, not yet ready for review. labels Feb 1, 2021
@krisgesling krisgesling requested a review from chrisveilleux June 1, 2021 21:25
Copy link
Member

@chrisveilleux chrisveilleux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am assuming that since the VK tests are now passing for this PR that this change is now good to merge.

@krisgesling
Copy link
Contributor Author

Yeah I'm not sure this ever really did anything - but that's why we tested it...

@krisgesling krisgesling merged commit 8a3cb6e into dev Jun 7, 2021
@krisgesling krisgesling deleted the bugfix/revert-vk-sleep branch June 7, 2021 21:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CLA: Yes Contributor License Agreement exists (see https://github.com/MycroftAI/contributors) Status: To be reviewed Concept accepted and PR has sufficient information for full review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants