This repository has been archived by the owner on Sep 8, 2024. It is now read-only.
Add optional message argument #2704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krisgesling
added
Status: To be reviewed
devs-mycroft
added
the
CLA: Yes
forslund
previously approved these changes
Sep 25, 2020
When called over the messagebus the message is passed to the handler, thereby throwing a TypeError as it wasn't expecting 2 positional args.
krisgesling
force-pushed
the
bugfix/settings-update-typeerror
branch
from
b093d7b to
5e8474c
Compare
|
Good call |
|
Voight Kampff Integration Test Succeeded (Results) |
1 similar comment
|
Voight Kampff Integration Test Succeeded (Results) |
|
I think this should be merged now as it's very minor and very correct |
|
I recently updated the branch protections so that a current "approve" review is needed before merges are allowed into master, and you can't review your own PR. I anticipate it being slightly annoying, but it enforces our standard practice and means the person reviewing has to be 100% clear that they approve the code in its current form to be merged. |
forslund
approved these changes
Oct 2, 2020
|
Thanks Ake 🙂 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When called over the messagebus the message is passed to the handler,
thereby throwing a TypeError as it wasn't expecting 2 positional args.
How to test
Ask Mycroft to "update configuration"
Contributor license agreement signed?