This repository has been archived by the owner on Sep 8, 2024. It is now read-only.
Fix enclosure shutdown #2538
Merged
Fix enclosure shutdown #2538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously it would always be killed, now it exits smoothly.
- split out enclosure determination code - Add docstrings - Increase logging
|
Voight Kampff Integration Test Succeeded (Results) |
chrisveilleux
approved these changes
Apr 17, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The enclosure was not using the standard startup scheme and would not shutdown cleanly and had to be killed.
Resolves #2492.
How to test
start the enclosure and then stop it and make sure it stops rather than kills:
The following is the expected output
Contributor license agreement signed?
CLA [ Yes ]