This repository has been archived by the owner on Sep 8, 2024. It is now read-only.
Bugfix Converse error #2503
Merged
Bugfix Converse error #2503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A skill can be missed if a skill is removed (due to an error) from the list during iteration
Padatious doesn't shouldn't report active like other skills, this only sent an empty skill entry to the active skills list.
Only allow non-empty skill IDs into the list of active skills
- Remove print statement - Remove unused import - Updated some docstrings
devs-mycroft
added
the
CLA: Yes
Including a case where an error occur.
forslund
force-pushed
the
bugfix/converse-error
branch
from
744fdf5 to
6dce109
Compare
chrisveilleux
approved these changes
Apr 1, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Converse errors, for example a skill that has been removed or an empty insertion (like from padatious) could cause a skill to be skipped. This handles the list by iterating over a copy instead of using the same one that a skill can be removed from.
In addition,
Will add a couple of unittests to this.
How to test
Ensure that get_response() still functions as intended.
Contributor license agreement signed?
CLA [ Yes ]