This repository has been archived by the owner on Sep 8, 2024. It is now read-only.
make stop-mycroft.sh also stop if skills are started from other module. #2449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devs-mycroft
added
the
CLA: Yes
|
Thanks @andlo, Looks and works as expected. Merging. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Make stop-mycroft.sh also stop if skills are started from other module.
If mycroft.skills are started from other module like ptvsd this make the stop function still posible to stop the skills service.
This is needed if running ptvsd remote debug to make sure skills are stoped as usal even though the proces is
and not as normal
How to test
Starting and stopping and restarting skills should still work as usal
Contributor license agreement signed?
CLA [ X ] (Whether you have signed a CLA - Contributor Licensing Agreement