Skip to content
This repository has been archived by the owner on Sep 8, 2024. It is now read-only.

Make venv-activate.sh compatible with sh and zsh #2439

Merged
merged 1 commit into from
Jan 3, 2020
Merged

Make venv-activate.sh compatible with sh and zsh #2439

merged 1 commit into from
Jan 3, 2020

Conversation

notdefine
Copy link

Description

Make venv-activate.sh compatible with sh and zsh

How to test

$ if [ "$0" == "$BASH_SOURCE" ]; then echo "a"; fi
Error: sh: 1: [: sh: unexpected operator

$ if [[ "$0" == "$BASH_SOURCE" ]]; then echo "a"; fi
Succed

Contributor license agreement signed?

CLA [X] (Whether you have signed a CLA - Contributor Licensing Agreement

$  if [ "$0" == "$BASH_SOURCE" ]; then echo "a"; fi
sh: 1: [: sh: unexpected operator
@devs-mycroft devs-mycroft added the CLA: Needed Need signed CLA from https://mycroft.ai/cla label Dec 26, 2019
@devs-mycroft
Copy link
Collaborator

Hello, @notdefine, thank you for helping with the Mycroft project! We welcome everyone
into the community and greatly appreciate your help as we work to build an AI
for Everyone.

To protect yourself, the project, and users of Mycroft technologies we require
a Contributor Licensing Agreement (CLA) before accepting any code
contribution. This agreement makes it crystal clear that along with your
code you are offering a license to use it within the confines of this project.
You retain ownership of the code, this is just a license.

Please visit https://mycroft.ai/cla to initiate this one-time signing. Thank
you!

@forslund
Copy link
Collaborator

Thanks for taking noticing and fixing this. Will merge after the CLA is handled.

@notdefine
Copy link
Author

notdefine commented Dec 27, 2019 via email

@krisgesling krisgesling added CLA: Yes Contributor License Agreement exists (see https://github.com/MycroftAI/contributors) and removed CLA: Needed Need signed CLA from https://mycroft.ai/cla labels Jan 3, 2020
@krisgesling
Copy link
Contributor

CLA received, thanks Thomas :)

@forslund
Copy link
Collaborator

forslund commented Jan 3, 2020

Re-verified this. It's definitely better bash code. And if it works in more shells it's better (only had dash available on this computer and that doesn't work for a bunch of other reasons).

Merging this now. Thank you.

@forslund forslund merged commit 43b9aa3 into MycroftAI:dev Jan 3, 2020
@notdefine notdefine deleted the bufix/make-venv-activate-compatible-with-sh-and-zsh branch January 3, 2020 12:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CLA: Yes Contributor License Agreement exists (see https://github.com/MycroftAI/contributors)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants