This repository has been archived by the owner on Sep 8, 2024. It is now read-only.
improve runtime #2402
Merged
improve runtime #2402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @maxbachmann! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2019-11-29 15:57:09 UTC |
devs-mycroft
added
the
CLA: Yes
|
This looks great, not related to your work in this PR but I do think the docstring for the
Would you mind handling this while you're touching this code. If you don't have the time I can do it later. |
forslund
approved these changes
Nov 29, 2019
|
@forslund so this should probably be changed to since it can be anything between -inf and +inf |
|
That sounds good 👍 |
|
ok applied |
|
Many thanks, Merging now. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR improved the runtime of the pronounce_number_en function.
Depending on the arguments provided it is 2-5 times as fast, mainly by reducing the need to copy the dicts from common_data_en.py and type conversions.
How to test
The behavior stays the same and is already covered by tests
Contributor license agreement signed?
CLA [ Yes ]