This repository has been archived by the owner on Sep 8, 2024. It is now read-only.
Cleanup of package install section of dev_setup #2390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the package list is used in two places this will reduce risks of changing in one place but not another.
devs-mycroft
added
the
CLA: Yes
chrisveilleux
approved these changes
Nov 21, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The install_deps function has been getting a bit messy. This performs a minor refactor moving the different os specific pieces into separate functions.
How to test
Check that a couple of the os's works as expected and read through the code verifying sanity.
Contributor license agreement signed?
CLA [ Yes ]