This repository has been archived by the owner on Sep 8, 2024. It is now read-only.
fix bug in isFractional_es and improve coverage #2356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix: isFractional_es() parsed fractions incorrectly - Update: earlier commit msg suggested another fix: - Month parsing not fixed - Several failing tests (skipped) document problem - TODO and an issue also created - Substantially improve parse_es.py test coverage - TODO or comment several found bugs - Many lines remain uncovered, incl possible bugs
devs-mycroft
added
the
CLA: Yes
|
Sorry for the delay on reviewing this one. It looks good so I'll just merge it and further work can be made to finish it up later. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
parse_es.isFractional_es() was pulling the wrong indices
from an array, due to old logic expecting array indices to
correspond to the Spanish words for fractions. The array
has been replaced with a dictionary, and the call to the
array reflects this.
How to test
See Coveralls.
Contributor license agreement signed?
CLA [ yes ]