This repository has been archived by the owner on Sep 8, 2024. It is now read-only.
Send listen on last sentence of utterance #2351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If rendering a chunk of a sentence takes too long time, the audio queue may run out and trigger the listening. This moves the listening trigger to after the last chunk.
devs-mycroft
added
the
CLA: Yes
chrisveilleux
approved these changes
Oct 4, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When
self.speak()is called withexpect_response=Truethe speech output system will generate a trigger for the listener. This has been prone to errors when multi-sentence phrases are sent to it triggering the listening between two sentences instead of the end.This is due to the trigger was set on the audio end message, which could occur mid utterance if a sentence was slow to render and the queue got empty.
This modifies the behaviour attaching the listen trigger to the last chunk only
How to test
Use self.ask_yesno() or get_response from a skill with a multi-sentence dialog and check that the listen is triggered correctly. To simulate a delay add a sleep in the execute method before the playback information is added to the queue (hereish)
Contributor license agreement signed?
CLA [ Yes ]