This repository has been archived by the owner on Sep 8, 2024. It is now read-only.
Add a safety harness in skill_manager main loop #2316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devs-mycroft
added
the
CLA: Yes
chrisveilleux
suggested changes
Sep 18, 2019
forslund
force-pushed
the
feature/safety-harness
branch
from
074f83c to
687b5c2
Compare
This captures any unhandled expressions and will at least make sure they're logged properly. (Exceptions in threads are mostly not printed to stdout). This sleeps slightly longer than normal (10 seconds) and then tries to resume normal operation.
forslund
force-pushed
the
feature/safety-harness
branch
from
687b5c2 to
4860b56
Compare
|
Updated according to feedback |
chrisveilleux
approved these changes
Sep 18, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This captures any unhandled expressions and will at least make sure
they're logged properly. (Exceptions in threads are mostly not printed
to stdout).
This sleeps slightly longer than normal (10 seconds) and then tries to resume
normal operation.
I've had one instance where skills reloading / updating stopped.
How to test
Make sure the normal loop runs as expected and reloads are handled correctly.
Contributor license agreement signed?
CLA [ Yes ]