This repository has been archived by the owner on Sep 8, 2024. It is now read-only.
Don't kill global events when shutting down skill #2296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
During skill shutdown remove_all_handlers() was called on all registered events. This would unregister all global events, such as settings updating, stop for all skills. Now the remove only will remove the instance connected to the skills method.
devs-mycroft
added
the
CLA: Yes
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
During skill shutdown remove_all_handlers() was called on all registered
events. This would unregister all global events, such as settings
updating, stop for all skills.
Now the remove only will remove the instance connected to the skills
method.
This is a likely cause for the failure to stopping the news playback.
How to test
Start skills, trigger a reload of a single skill. Ensure that the news skill can be stopped still.
Contributor license agreement signed?
CLA [ Yes ]