Skip to content
This repository has been archived by the owner on Sep 8, 2024. It is now read-only.

Switch all mock imports to unittest.mock imports #2274

Merged
merged 3 commits into from
Aug 27, 2019

Conversation

mathmauney
Copy link
Contributor

Description

(Description of what the PR does, such as fixes # {issue number})
Takes care of #2261 by switching all mock imports. I've tested on python 3.4.8 and 3.6.7.

How to test

(Description of how to validate or test this PR)
Run start-mycroft.sh unittest, though Travis should take care of this.

Contributor license agreement signed?

CLA [yes] (Whether you have signed a CLA - Contributor Licensing Agreement

@pep8speaks
Copy link

pep8speaks commented Aug 26, 2019

Hello @mathmauney! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2019-08-27 09:00:40 UTC

@devs-mycroft devs-mycroft added the CLA: Needed Need signed CLA from https://mycroft.ai/cla label Aug 26, 2019
@devs-mycroft
Copy link
Collaborator

Hello, @mathmauney, thank you for helping with the Mycroft project! We welcome everyone
into the community and greatly appreciate your help as we work to build an AI
for Everyone.

To protect yourself, the project, and users of Mycroft technologies we require
a Contributor Licensing Agreement (CLA) before accepting any code
contribution. This agreement makes it crystal clear that along with your
code you are offering a license to use it within the confines of this project.
You retain ownership of the code, this is just a license.

Please visit https://mycroft.ai/cla to initiate this one-time signing. Thank
you!

@forslund
Copy link
Collaborator

Thanks @mathmauney, looks really good! Seems there are a couple of pep-8 issues still lingering. Could you look at those as well?

Also could remove the mock dependency from test-requirements.txt?

@devs-mycroft devs-mycroft added CLA: Yes Contributor License Agreement exists (see https://github.com/MycroftAI/contributors) and removed CLA: Needed Need signed CLA from https://mycroft.ai/cla labels Aug 26, 2019
@mathmauney
Copy link
Contributor Author

Done and done.

@forslund forslund force-pushed the refactor/issue-2261 branch from c038a68 to 6bca152 Compare August 27, 2019 08:28
@forslund forslund force-pushed the refactor/issue-2261 branch from b6ec430 to 21ecf79 Compare August 27, 2019 09:00
@forslund
Copy link
Collaborator

I've rebased the branch and squashed the PEP8 commits. Looks very good, thank you for fixing this! Merging

@forslund forslund merged commit 2ddb230 into MycroftAI:dev Aug 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CLA: Yes Contributor License Agreement exists (see https://github.com/MycroftAI/contributors)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants