This repository has been archived by the owner on Sep 8, 2024. It is now read-only.
Feature/better no confirm listening #2267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devs-mycroft
added
the
CLA: Yes
forslund
force-pushed
the
feature/better_no_confirm_listening
branch
from
1a88082 to
f96a692
Compare
|
I cleaned up the commit history and added the new parameter to the docstring. Merging now. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Keeps audio immediately after wake word is detected for us in STT if
confim_listeningis false. This improves performance of queries that quickly follow the wake word.How to test
With
confirm_listeningset to false through web settings Mycroft should respond to a continuous utterance like "Hey Mycroft what time is it?"Contributor license agreement signed?
CLA [Yes] (Whether you have signed a CLA - Contributor Licensing Agreement