Skip to content
This repository has been archived by the owner on Sep 8, 2024. It is now read-only.

support ubuntu & mint (debian like) OS #2209

Merged
merged 1 commit into from
Aug 2, 2019

Conversation

fermulator
Copy link
Contributor

@fermulator fermulator commented Jul 14, 2019

Description

add os_is() and os_is_like() call support for debian-like OSes ; specifically Mint but also ~Ubuntu; (Ubuntu should already be covered via "is like debian" but now we're extra covered)
Also if there is no OS match, we should really prompt the user for what to do.

fixes #2207

How to test

run dev_setup.sh on Linux Mint variant (positive test)
(I'm confident this didn't break debian/ubuntu, but in case we're worried test there too)

I tested the "continue?" clause for no OS match by adding (forging) a return in the os_is() and os_is_like() methods temporarily

Contributor license agreement signed?

  • CLA

add `os_is()` and `os_is_like()` call support for debian-like OSes (specifically Mint, but also cover Ubuntu)
Ubuntu should already be covered via "is like debian" (but now we're extra covered)

Also if there is NO match, we should really prompt the user for what to do.
@devs-mycroft
Copy link
Collaborator

Hello, @fermulator, thank you for helping with the Mycroft project! We welcome everyone
into the community and greatly appreciate your help as we work to build an AI
for Everyone.

To protect yourself, the project, and users of Mycroft technologies we require
a Contributor Licensing Agreement (CLA) before accepting any code
contribution. This agreement makes it crystal clear that along with your
code you are offering a license to use it within the confines of this project.
You retain ownership of the code, this is just a license.

Please visit https://mycroft.ai/cla to initiate this one-time signing. Thank
you!

@devs-mycroft devs-mycroft added the CLA: Needed Need signed CLA from https://mycroft.ai/cla label Jul 14, 2019
@fermulator
Copy link
Contributor Author

Hello, @fermulator, thank you for helping with the Mycroft project! We welcome everyone
into the community and greatly appreciate your help as we work to build an AI
for Everyone.

To protect yourself, the project, and users of Mycroft technologies we require
a Contributor Licensing Agreement (CLA) before accepting any code
contribution. This agreement makes it crystal clear that along with your
code you are offering a license to use it within the confines of this project.
You retain ownership of the code, this is just a license.

Please visit https://mycroft.ai/cla to initiate this one-time signing. Thank
you!

(in fact I signed this BEFORE submitting the PR, but maybe there is a delay?)

@forslund
Copy link
Collaborator

I think this looks really good, going to test it during the week and when your CLA signature drops in I'll merge this unless I find something (but it looks nice, simple and good)

@forslund
Copy link
Collaborator

A brief explanation to the CLA delay. There is a bit of manual intervention needed to verify the signature and extract github username. I'm not involved in the process so I can't really speed it up :/

@fermulator
Copy link
Contributor Author

(CLA still pending? hmmm)

@forslund
Copy link
Collaborator

Hmm, I know the CLA-mail was sent out on Monday morning. I'll poke the person responsible and see if the document has arrived and the list just haven't been updated...

@forslund
Copy link
Collaborator

Apparently your signature did not arrive. You should have a new e-mail with signing instructions in your email now.

@fermulator
Copy link
Contributor Author

fermulator commented Jul 19, 2019

(clicked through the CLA again)
EDIT: did the final process on Jul22, I did not realize there were steps beyond the "clicking" portion initially ... completed the "hellosign" now

@devs-mycroft devs-mycroft added CLA: Yes Contributor License Agreement exists (see https://github.com/MycroftAI/contributors) and removed CLA: Needed Need signed CLA from https://mycroft.ai/cla labels Jul 27, 2019
@forslund
Copy link
Collaborator

forslund commented Aug 2, 2019

Sorry for the delay, the CLA dropped but I'm on vacation so I'm a bit behind on communication. Merging this now.

Many thanks for the nice and clean contribution!

@forslund forslund merged commit 3a68f75 into MycroftAI:dev Aug 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CLA: Yes Contributor License Agreement exists (see https://github.com/MycroftAI/contributors)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dev_setup.sh fails on Linux Mint
3 participants