Skip to content
This repository has been archived by the owner on Sep 8, 2024. It is now read-only.

Only report STT timing if transcription exists #2198

Merged
merged 2 commits into from
Jul 10, 2019

Conversation

forslund
Copy link
Collaborator

@forslund forslund commented Jul 9, 2019

Description

To clean up the metrics log empty transcriptions from false activation
are no longer reported.

How to test

Make sure the speech client still runs as expected.

Contributor license agreement signed?

CLA [ Yes ]

@pep8speaks
Copy link

pep8speaks commented Jul 9, 2019

Hello @forslund! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2019-07-09 20:54:55 UTC

@forslund forslund requested a review from chrisveilleux July 9, 2019 20:53
@devs-mycroft devs-mycroft added the CLA: Yes Contributor License Agreement exists (see https://github.com/MycroftAI/contributors) label Jul 9, 2019
forslund added 2 commits July 9, 2019 22:54
To clean up the metrics log empty transcriptions from false activation
are no longer reported.
@forslund forslund force-pushed the feature/no-report-empty branch from 72f7dee to b79bd0e Compare July 9, 2019 20:54
@forslund forslund merged commit ebda6a8 into MycroftAI:dev Jul 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CLA: Yes Contributor License Agreement exists (see https://github.com/MycroftAI/contributors)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants