This repository has been archived by the owner on Sep 8, 2024. It is now read-only.
Fetch CLI log path from config if available #2192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devs-mycroft
added
the
CLA: Yes
penrods
suggested changes
Jul 11, 2019
mycroft/client/text/__main__.py
Outdated
| start_log_monitor("/var/log/mycroft/skills.log") | ||
| start_log_monitor("/var/log/mycroft/voice.log") | ||
| # logs when using Debian package TODO: Unify all | ||
| start_log_monitor("/var/log/mycroft-skills.log") |
There was a problem hiding this comment.
Does the Debian package write to /var/log/mycroft-skills.log anymore? I don't have a Mark 1 up at the moment to check., but I'm pretty sure it doesn't. If not, let's remove support for those old logs.
There was a problem hiding this comment.
You're right, those aren't needed anymore. Mark-1 switched a long time ago.
penrods
approved these changes
Jul 11, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Make log location configurable for CLI.
How to test
Set the config parameter "log_dir" to something and ensure that the CLI doesn't show anything.
Contributor license agreement signed?
CLA [ Yes ]