Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add features related to status codes #82

Merged
merged 5 commits into from
Jul 13, 2023
Merged

feat: add features related to status codes #82

merged 5 commits into from
Jul 13, 2023

Conversation

chanhihi
Copy link
Member

@chanhihi chanhihi commented Jul 12, 2023 •
edited by cjho0316
Loading

  • Suggestion status code enum #21
  • discussions 21번에 의거해서 status code를 알아보기 쉽게 변경하였습니다.
  • createErrorResponse가 dts 객체를 매개변수로 받아 configureErrorPages 합니다.
  • configureErrorPages가 에러 페이지의 http status code를 set 합니다.
  • default.config에 있는 errorpage의 경로를 받아서 statuscode.html의 파일에 접근합니다.
  • 접근 불가능한 에러 페이지의 경우(ex: 402) text/plain으로 반환합니다.
  • 접근 가능한 에러 페이지의 경우(ex: 404) text/html로 반환합니다.
image

@chanhihi chanhihi linked an issue Jul 12, 2023 that may be closed by this pull request
feat: add features related to status codes #81
Closed
@chanhihi chanhihi changed the title 81 feat add features related to status codes feat: add features related to status codes Jul 12, 2023
@chanhihi chanhihi marked this pull request as ready for review July 12, 2023 15:42
middlefitting
middlefitting approved these changes Jul 12, 2023
View reviewed changes
Copy link
Member

@middlefitting middlefitting left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

에러페이지 귀하군요. 고생하셨습니다 ㅎㅎ

@chanhihi chanhihi requested review from Clearsu and cjho0316 July 12, 2023 15:47
Clearsu
Clearsu approved these changes Jul 13, 2023
View reviewed changes
Copy link
Collaborator

@Clearsu Clearsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생 많으셨습니다.

@chanhihi chanhihi merged commit 06e6253 into develop Jul 13, 2023
@chanhihi chanhihi deleted the 81-feat-add-features-related-to-status-codes branch July 13, 2023 04:39
@cjho0316
Copy link
Collaborator

항상 저희 팀의 인프라를 책임져주시는 개발자 찬히히님 대단히 감사합니다

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@middlefitting middlefitting middlefitting approved these changes

@Clearsu Clearsu Clearsu approved these changes

@cjho0316 cjho0316 Awaiting requested review from cjho0316

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: add features related to status codes
4 participants
@chanhihi @cjho0316 @Clearsu @middlefitting