-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TASK] Update the development tools #1390
base: main
Are you sure you want to change the base?
Conversation
d076a62
to
4f8f1de
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, I see, it breaks something, and this PR is now 'draft'.
Personally (YMMV), I'm not super-keen to update things if there's no need to. If it ain't broke, don't fix it (because you'll just end up breaking more stuff).
The PHIVE PHARs will be installed with the latest permissable version locally upon running phive update
. Do we not also run that during CI? If so, we don't need to keep updating these files. If not, maybe we should - ?
We concluded that we needed to restrict versions of the static analysis tools in Composer to avoid breaking updates, though I wonder if we might be able to use Tilde Version Range - if the tools really adhere to semver, then point releases should not break anything.
No specific changes requested beyond fixing the CI.
We should probably use |
4f8f1de
to
44cc3e2
Compare
Okay, then let's only update the tools when they either bring features of bug fixes we need/want, or when we'll need to update our code for the new version.
CI is running
|
No description provided.