Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TASK] Update the development tools #1390

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

oliverklee
Copy link
Contributor

No description provided.

@oliverklee oliverklee added this to the 8.0.0 milestone Jan 19, 2025
@oliverklee oliverklee self-assigned this Jan 19, 2025
@oliverklee oliverklee marked this pull request as draft January 19, 2025 10:06
@coveralls
Copy link

coveralls commented Jan 19, 2025

Coverage Status

coverage: 97.062%. remained the same
when pulling 44cc3e2 on task/update-dev-tools
into 97cf851 on main.

@oliverklee oliverklee force-pushed the task/update-dev-tools branch from d076a62 to 4f8f1de Compare January 25, 2025 10:03
@oliverklee oliverklee marked this pull request as ready for review January 25, 2025 10:04
@oliverklee oliverklee requested review from JakeQZ and removed request for JakeQZ January 25, 2025 10:04
@oliverklee oliverklee marked this pull request as draft January 25, 2025 10:05
Copy link
Contributor

@JakeQZ JakeQZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I see, it breaks something, and this PR is now 'draft'.

Personally (YMMV), I'm not super-keen to update things if there's no need to. If it ain't broke, don't fix it (because you'll just end up breaking more stuff).

The PHIVE PHARs will be installed with the latest permissable version locally upon running phive update. Do we not also run that during CI? If so, we don't need to keep updating these files. If not, maybe we should - ?

We concluded that we needed to restrict versions of the static analysis tools in Composer to avoid breaking updates, though I wonder if we might be able to use Tilde Version Range - if the tools really adhere to semver, then point releases should not break anything.

No specific changes requested beyond fixing the CI.

@JakeQZ
Copy link
Contributor

JakeQZ commented Jan 26, 2025

We should probably use ~ version in the PHIVE config, so that contributors don't pick up breaking changes.

@oliverklee oliverklee force-pushed the task/update-dev-tools branch from 4f8f1de to 44cc3e2 Compare January 26, 2025 10:14
@oliverklee
Copy link
Contributor Author

Personally (YMMV), I'm not super-keen to update things if there's no need to. If it ain't broke, don't fix it (because you'll just end up breaking more stuff).

Okay, then let's only update the tools when they either bring features of bug fixes we need/want, or when we'll need to update our code for the new version.

The PHIVE PHARs will be installed with the latest permissable version locally upon running phive update. Do we not also run that during CI? If so, we don't need to keep updating these files. If not, maybe we should - ?

CI is running phive install (not phive update) to get the exact versions specified as installed in phars.xml. That's what contributors are expected to use and what's documented in CONTRIBUTING.md. This ensures that tests results are reproducible (except for cases like removed/expired GPG key).

phive update is intended to update the tools, and it changes phars.xml.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants