Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TASK] Add some more unit tests for AtRuleBlockList #934

Merged
merged 2 commits into from
Feb 16, 2025
Merged

[TASK] Add some more unit tests for AtRuleBlockList #934

merged 2 commits into from
Feb 16, 2025

Conversation

oliverklee
Copy link
Contributor

@oliverklee oliverklee commented Feb 15, 2025 •
edited
Loading

Part of #757

@oliverklee oliverklee requested a review from JakeQZ February 15, 2025 12:34
@oliverklee oliverklee self-assigned this Feb 15, 2025
@coveralls
Copy link

coveralls commented Feb 15, 2025 •
edited
Loading

Coverage Status

coverage: 50.747% (+0.4%) from 50.374%
when pulling f212293 on task/atruleblocklist-tests
into 6775b97 on main.

JakeQZ
JakeQZ requested changes Feb 16, 2025
View reviewed changes
Copy link
Contributor

@JakeQZ JakeQZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not cover much code from CSSList, though.

If it covers some, I guess the @covers annotation is correct.

I found a typo. Otherwise all good.

tests/Unit/CSSList/AtRuleBlockListTest.php Outdated Show resolved Hide resolved
@oliverklee oliverklee force-pushed the task/atruleblocklist-tests branch from 88c6c2b to 4fc3208 Compare February 16, 2025 09:18
@oliverklee @JakeQZ
Fix typo
f212293 
Co-authored-by: JakeQZ <[email protected]>
@oliverklee
Copy link
Contributor Author

I've updated the commit description.

@oliverklee oliverklee requested a review from JakeQZ February 16, 2025 09:19
@JakeQZ JakeQZ merged commit 9682877 into main Feb 16, 2025
21 checks passed
@JakeQZ JakeQZ deleted the task/atruleblocklist-tests branch February 16, 2025 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JakeQZ JakeQZ JakeQZ approved these changes

Assignees

@oliverklee oliverklee

Labels
None yet
Projects
None yet
Milestone
9.0.0: Drop support for PHP < 7.2 and...
Development

Successfully merging this pull request may close these issues.
3 participants
@oliverklee @coveralls @JakeQZ