Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TASK] Mark OutputFormatter as @internal #896

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

oliverklee
Copy link
Contributor

This class should only be used for formatting CSS from within this library. It is not intended to be called from outside.

@coveralls
Copy link

coveralls commented Feb 10, 2025

Coverage Status

coverage: 51.335%. remained the same
when pulling 0aa95bd on task/internal-formatter
into d71ff28 on main.

Copy link
Contributor

@JakeQZ JakeQZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think so.

@sabberworm, would you agree?

@JakeQZ
Copy link
Contributor

JakeQZ commented Feb 11, 2025

Actually maybe not. See #895 (comment).

It might not be used from the outside, but may need to be constructed and passed around, depending on how we resolve the circular dependency.

@oliverklee oliverklee force-pushed the task/internal-formatter branch from f20a6af to 1696d58 Compare February 11, 2025 11:09
@oliverklee
Copy link
Contributor Author

I've proposed a path forward in #907.

@oliverklee oliverklee force-pushed the task/internal-formatter branch 3 times, most recently from 370dee5 to 8c36d23 Compare February 14, 2025 11:23
@oliverklee
Copy link
Contributor Author

@sabberworm ping

@oliverklee oliverklee force-pushed the task/internal-formatter branch from 8c36d23 to 0a17c5c Compare February 14, 2025 22:30
@JakeQZ
Copy link
Contributor

JakeQZ commented Feb 15, 2025

Marking as draft pending #907,

@JakeQZ JakeQZ marked this pull request as draft February 15, 2025 02:03
@oliverklee oliverklee force-pushed the task/internal-formatter branch 6 times, most recently from c068eda to 1f815e0 Compare February 16, 2025 21:19
This class should only be used for formatting CSS from
within this library. It is not intended to be called
from outside.
@oliverklee oliverklee force-pushed the task/internal-formatter branch from 1f815e0 to 0aa95bd Compare February 18, 2025 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants