CSSRule->__toString doesn't work with sized values

[lieutdan13]

If I have a CSS rule as follows (this is in your example css):
div.rating-cancel,div.star-rating{width:17px;height:15px;}

The CSSRule->__toString either throws an error, or it looks like this:
width: Object;

The problem is on line 707 when it tries to implode a comma into the values. When a value is a CSSSize, it produces the above result.

For you to test this, in your CSSParserTests.php file,
change line 19 to:
$oDoc = $oParser->parse();
and add this line after the catch clause
echo $oDoc->__toString();

[sabberworm]

The code in question is taking advantage of the fact that implode will call __toString() on any object it encounters (which is needed for all CSSValues, not just CSSSize). Unfortunately, older versions of PHP (pre-5.2) do not support this. I’m not sure whether to work around this or to mark it wontfix and set PHP 5.2 as the minimum requirement for this library.

[lieutdan13]

I have fixed the issue by looping through the array and calling __toString if the element is an object, using the string if it is not, and adding commas accordingly. I can send you a diff if you would like.
I also added a few methods of my own to CSSDocument that returns a style as a string instead of the entire rule.

[sabberworm]

I would be very interested in those changes you made to the CSSDocument. Just fork my repository and push your changes.

[lieutdan13]

I think I have committed my changes. I am a noob @ both git and github, so please let me know either way if you can or cannot see my changes or if I did it incorrectly.

[sabberworm]

You need to use the “git push” command to push changes that you’ve checked in to the github repository.

[lieutdan13]

Ok. Done.

[sabberworm]

I’ve commented on your commits. Please send a pull request after having worked through them so I can merge your changes.

[sabberworm]

I think we’re dropping PHP pre-5.2 so I’ll close this.