Revert PRs #21, #22 #23
Conversation
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @MusicalNinjaDad - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 3 issues found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
| ## Python 2.0.0 | ||
|
|
||
| - **Breaking:** Changed top level module name to `fizzbuzz`. Use `from fizzbuzz.fizzbuzzo3 import fizzbuzz` | ||
| for rust implementation or `from fizzbuzz.fizzbuzzpy import fizzbuzz` for python implementation (slower). |
There was a problem hiding this comment.
question: Clarification needed on removal of Python 2.0.0 changelog entry.
The removal of the entire section for Python 2.0.0 might confuse users looking for migration details. Consider keeping a summarized version or a link to migration documentation.
| @@ -1,5 +1,4 @@ | |||
| { | |||
| // "image": "ghcr.io/musicalninjas/pyo3-devcontainer:latest", // untested with mac, expect issues due to x_64 rust installation | |||
There was a problem hiding this comment.
question: Explanation needed for removal of devcontainer image comment.
If the image is now tested and compatible with Mac, documenting this change could be beneficial for developers using different environments.
| @@ -1,4 +1,3 @@ | |||
| name: Deploy Rust | |||
There was a problem hiding this comment.
question: Check if the removal of the workflow name was intentional.
Removing the name of a GitHub Actions workflow can affect readability and logging. If this was unintentional, it might be worth adding it back.
This reverts commits
c132883
869663a