Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamically update remote stream tags by merge instead of replace - i… #2089

Closed

Conversation

geneticdrift
Copy link
Contributor

…ssue #1400

Clients can use addtagid to set tags for remote streams. For example a radio station genre. Then when the song title is updated from the remote stream, only the title is updated but other tags are preserved.

…ssue MusicPlayerDaemon#1400

Clients can use addtagid to set tags for remote streams. For example a
radio station genre. Then when the song title is updated from the remote
stream, only the title is updated but other tags are preserved.
@MaxKellermann
Copy link
Member

But what if the stream switches to a new song which doesn't have a certain tag type; e.g. it has no "Composer"; then the Composer from the previous song remains forever, doesn't it?

@geneticdrift
Copy link
Contributor Author

You are right.
It's a bad idea to try to shoehorn a "Radio station" entity into a model that only defines a "Song". It doesn't fit.
Unless the model directly supported entities such as Radio station, Podcast, Audio book etc. it will just be a hack.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants