Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

android: Correctly move the libmpd.so output #1973

Closed
wants to merge 1 commit into from

Conversation

DDRBoxman
Copy link
Contributor

libmpd.so was getting written as a file called arm64-v8a instead of arm64-v8a/libmpd.so

libmpd.so was getting written as a file called `arm64-v8a` instead of `arm64-v8a/libmpd.so`
@MaxKellermann
Copy link
Member

Is there really no way to do that natively with Meson, without resorting to a shell script?
(And btw your shell script is unsafe .... it's the kind of awful shell script I want to avoid - shell is the worst of all programming languages.)

@MaxKellermann
Copy link
Member

No reply.

@DDRBoxman
Copy link
Contributor Author

Looking around I didn't find a way to have meson just move a file, not sure what the right fix is here.

@MaxKellermann
Copy link
Member

Maybe moving the file wasn't a good idea anyway, because moving an output file will cause it to be rebuilt; and copying files is something Meson can do: https://mesonbuild.com/Fs-module.html#copyfile

@DDRBoxman
Copy link
Contributor Author

Ah, nice I'll take a look at that, thanks!

@DDRBoxman
Copy link
Contributor Author

Hmm, looks like fs can't depend on other modules and is used to move stuff around for the build not after.
I can at least redo the script in python so it's not bash.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants