android: Add a text field to display the devices network address #1930
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DDRBoxman
force-pushed
the
android_network_address
branch
from
eb6119b to
35df3ad
Compare
DDRBoxman
changed the title
| if (!address.getAddress().isLinkLocalAddress() && !address.getAddress().isLoopbackAddress()) { | ||
| InetAddress address1 = address.getAddress(); | ||
| String hostAddress = address1.getHostAddress(); | ||
| if (hostAddress != null && hostAddress.contains(".")) { |
There was a problem hiding this comment.
Ah yeah that's definitely cleaner, thanks.
DDRBoxman
force-pushed
the
android_network_address
branch
from
35df3ad to
c4c1044
Compare
Comment on lines
-38
to
+63
| android:id="@+id/log_list" | ||
| android:layout_width="match_parent" | ||
| android:layout_height="wrap_content" | ||
| android:paddingTop="10dip" /> | ||
| android:id="@+id/log_list" | ||
| android:layout_width="match_parent" | ||
| android:layout_height="wrap_content" | ||
| android:paddingTop="10dip" /> |
There was a problem hiding this comment.
Please watch out for (unrelated) whitespace changes next time. If you think whitespace (or coding style) should be changed, make this a separate commit. Cramming multiple things into one commit makes understanding the changes harder than necessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.