"sticker find" support for sort and window parameter and handling for integer values #1895
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcorporation
force-pushed
the
sticker_sort_window_int
branch
from
56ecde8 to
2f2cc56
Compare
This was referenced Nov 7, 2023
jcorporation
force-pushed
the
sticker_sort_window_int
branch
from
2f2cc56 to
9368087
Compare
2 tasks
jcorporation
force-pushed
the
sticker_sort_window_int
branch
2 times, most recently
from
97e84da to
4f0c1ee
Compare
|
Squashed into one commit, rebased on current master and some code cleanups. |
|
@MaxKellermann: Any chance that this pull request will be merged in the near future? |
jcorporation
force-pushed
the
sticker_sort_window_int
branch
3 times, most recently
from
53c3512 to
a90d969
Compare
|
Rebased and added an "eq" operator for int values. |
|
@jcorporation These changes look great, they're exactly what I was hoping for as this would also close #1103 which is to sort and limit sticker responses. Hopefully this can be merged soon! |
The three new compare operators "eq", "gt" and "lt" are casting the values to int. Sort supports: - uri: sort by uri - value: sort by value as string - value_int: casts value to int Closes MusicPlayerDaemon#1894
jcorporation
force-pushed
the
sticker_sort_window_int
branch
from
a90d969 to
45553c5
Compare
|
Rebase to current master |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an enhanced version of #1885