Skip to content

Commit

Permalink
tag: new tag Label
Browse files Browse the repository at this point in the history
  • Loading branch information
skidoo23 committed Oct 17, 2018
1 parent a2cd66e commit fbea965
Show file tree
Hide file tree
Showing 4 changed files with 19 additions and 9 deletions.
1 change: 1 addition & 0 deletions doc/user.rst
Original file line number Diff line number Diff line change
Expand Up @@ -770,6 +770,7 @@ When scanning or playing a song, :program:`MPD` parses its metadata. The followi
* **performer**: the artist who performed the song.
* **comment**: a human-readable comment about this song. The exact meaning of this tag is not well-defined.
* **disc**: the decimal disc number in a multi-disc album.
* **label**: the name of the label or publisher.
* **musicbrainz_artistid**: the artist id in the `MusicBrainz <https://picard.musicbrainz.org/docs/mappings/>`_ database.
* **musicbrainz_albumid**: the album id in the `MusicBrainz <https://picard.musicbrainz.org/docs/mappings/>`_ database.
* **musicbrainz_albumartistid**: the album artist id in the `MusicBrainz <https://picard.musicbrainz.org/docs/mappings/>`_ database.
Expand Down
21 changes: 14 additions & 7 deletions src/tag/Id3Scan.cxx
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright 2003-2017 The Music Player Daemon Project
* Copyright 2003-2018 The Music Player Daemon Project
* http://www.musicpd.org
*
* This program is free software; you can redistribute it and/or modify
Expand Down Expand Up @@ -38,12 +38,13 @@
#include <string.h>
#include <stdlib.h>

# ifndef ID3_FRAME_COMPOSER
# define ID3_FRAME_COMPOSER "TCOM"
# endif
# ifndef ID3_FRAME_DISC
# define ID3_FRAME_DISC "TPOS"
# endif
#ifndef ID3_FRAME_COMPOSER
#define ID3_FRAME_COMPOSER "TCOM"
#endif

#ifndef ID3_FRAME_DISC
#define ID3_FRAME_DISC "TPOS"
#endif

#ifndef ID3_FRAME_ARTIST_SORT
#define ID3_FRAME_ARTIST_SORT "TSOP"
Expand All @@ -61,6 +62,10 @@
#define ID3_FRAME_ORIGINAL_RELEASE_DATE "TDOR"
#endif

#ifndef ID3_FRAME_LABEL
#define ID3_FRAME_LABEL "TPUB"
#endif

gcc_pure
static id3_utf8_t *
tag_id3_getstring(const struct id3_frame *frame, unsigned i) noexcept
Expand Down Expand Up @@ -317,6 +322,8 @@ scan_id3_tag(struct id3_tag *tag, TagHandler &handler) noexcept
handler);
tag_id3_import_text(tag, ID3_FRAME_DISC, TAG_DISC,
handler);
tag_id3_import_text(tag, ID3_FRAME_LABEL, TAG_LABEL,
handler);

tag_id3_import_musicbrainz(tag, handler);
tag_id3_import_ufid(tag, handler);
Expand Down
3 changes: 2 additions & 1 deletion src/tag/Names.c
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright 2003-2017 The Music Player Daemon Project
* Copyright 2003-2018 The Music Player Daemon Project
* http://www.musicpd.org
*
* This program is free software; you can redistribute it and/or modify
Expand Down Expand Up @@ -37,6 +37,7 @@ const char *const tag_item_names[TAG_NUM_OF_ITEM_TYPES] = {
[TAG_PERFORMER] = "Performer",
[TAG_COMMENT] = "Comment",
[TAG_DISC] = "Disc",
[TAG_LABEL] = "Label",

/* MusicBrainz tags from http://musicbrainz.org/doc/MusicBrainzTag */
[TAG_MUSICBRAINZ_ARTISTID] = "MUSICBRAINZ_ARTISTID",
Expand Down
3 changes: 2 additions & 1 deletion src/tag/Type.h
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright 2003-2017 The Music Player Daemon Project
* Copyright 2003-2018 The Music Player Daemon Project
* http://www.musicpd.org
*
* This program is free software; you can redistribute it and/or modify
Expand Down Expand Up @@ -51,6 +51,7 @@ enum TagType
TAG_PERFORMER,
TAG_COMMENT,
TAG_DISC,
TAG_LABEL,

TAG_MUSICBRAINZ_ARTISTID,
TAG_MUSICBRAINZ_ALBUMID,
Expand Down

0 comments on commit fbea965

Please sign in to comment.