Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor :with_observation and :with_description query parameters #2589

Merged
merged 9 commits into from
Dec 20, 2024

Conversation

nimmolo
Copy link
Contributor

@nimmolo nimmolo commented Dec 20, 2024

  • DRYs up some repetitive parameter declarations
  • Switches param names for the outer :ids of coerced queries.

The latter are now named to refer to the outer table: :obs_ids or :desc_ids, to keep them distinct from the :ids param for the inner table.

For example, when coercing from Observation to ImageWithObservations, the param named :ids is converted to :obs_ids to allow it to be handled differently from the param that should mean a set of image :ids.

@nimmolo nimmolo changed the title Refactor :with_observation query parameters Refactor :with_observation and :with_description query parameters Dec 20, 2024
@coveralls
Copy link
Collaborator

coveralls commented Dec 20, 2024

Coverage Status

Changes unknown
when pulling 817eb80 on standardize-controller-indexes
into ** on main**.

@nimmolo nimmolo marked this pull request as ready for review December 20, 2024 09:44
@nimmolo nimmolo merged commit d3b8fe8 into main Dec 20, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants