Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge pattern, regex, advanced search flavors into query params #2587

Merged
merged 7 commits into from
Dec 20, 2024

Conversation

nimmolo
Copy link
Contributor

@nimmolo nimmolo commented Dec 19, 2024

Merges Query params for searches into the base class for Observation, Location, Name. (This has already been done for all the other searchable models.)

Also, folds in ImageInsideObservation and ObservationNeedsNaming flavors into :all.

There should be no change in front-end behavior, apart from a few (improved?) query result titles in Advanced Search.


Requested front-end spot tests

  • Advanced search
  • Pattern search
  • Observations Needing Identification
  • The obscure? but probably useful ability to navigate between the show image pages of all images occurring within a query of "Observations of x". In other words, the "outer" query is your Obs query: you should be able to step between each image of each obs, in order, and it should then take you through the images of the next obs, and the next, etc.

@coveralls
Copy link
Collaborator

coveralls commented Dec 19, 2024

Coverage Status

coverage: 93.523% (+0.005%) from 93.518%
when pulling ac55640 on standardize-controller-indexes
into 5d35379 on main.

@nimmolo nimmolo marked this pull request as ready for review December 19, 2024 01:42
@nimmolo nimmolo changed the title Merge pattern and regex search params Merge pattern and regex search flavors into query params Dec 19, 2024
@nimmolo nimmolo changed the title Merge pattern and regex search flavors into query params Merge pattern, regex, advanced search flavors into query params Dec 20, 2024
@nimmolo nimmolo merged commit b5bba70 into main Dec 20, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants