-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Query param simplifications: Move more params into main query classes #2585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ize-controller-indexes
Add missing where is_collection_location
with_observations_for_project
into with_observations
for_project
and for_species_list
into main query classes
for_project
and for_species_list
into main query classesfor_project
into main query classes
Should return nil with :by_editor, because that implies we only want Location records
for_project
into main query classes
JoeCohen
approved these changes
Dec 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No visible problems when played around in the branch for > 1hr.
Appreciate all that testing, @JoeCohen |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gets us a huge step closer to handling index params in a predictable way, and vastly reduces the number of Query subclasses. Should not change anything on the front end, however!
Front end tests: We want to be sure that the links for these still work as expected. I believe all the important ones are well tested though, so if this seems like a ridiculous number of indexes to check, please just spot check.
Or not. I'm inclined to just merge it and move on, i'm sure we'll hear about it if anything's not working as expected.