Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Query param simplifications: Move more params into main query classes #2585

Merged
merged 16 commits into from
Dec 18, 2024

Conversation

nimmolo
Copy link
Contributor

@nimmolo nimmolo commented Dec 17, 2024

Gets us a huge step closer to handling index params in a predictable way, and vastly reduces the number of Query subclasses. Should not change anything on the front end, however!

Front end tests: We want to be sure that the links for these still work as expected. I believe all the important ones are well tested though, so if this seems like a ridiculous number of indexes to check, please just spot check.

Or not. I'm inclined to just merge it and move on, i'm sure we'll hear about it if anything's not working as expected.


  • "Observations for Project"
  • "Locations with Observations for Project"
  • "Names with Observations for Project"
  • "Images with Observations for Project"

  • "Observations in Species List"
  • "Locations with Observations in Species List"
  • "Names with Observations in Species List"
  • "Images with Observations in Species List"

  • "Observations by User"
  • "Locations with Observations by User"
  • "Names with Observations by User"
  • "Images with Observations by User"

  • "Location Descriptions"
  • "Location Descriptions by Author"
  • "Location Descriptions by Editor"
  • "Location Descriptions by User"

  • "Locations with Descriptions"
  • "Locations with Descriptions by Author"
  • "Locations with Descriptions by Editor"
  • "Locations with Descriptions by User"

  • "Name Descriptions"
  • "Name Descriptions by Author"
  • "Name Descriptions by Editor"
  • "Name Descriptions by User"

  • "Names with Descriptions"
  • "Names with Descriptions by Author"
  • "Names with Descriptions by Editor"
  • "Names with Descriptions by User"

  • "Images for Project"
  • "Images by Editor"

  • "Locations by User"
  • "Locations by Editor"

  • "Names by User"
  • "Names by Editor"

@coveralls
Copy link
Collaborator

coveralls commented Dec 17, 2024

Coverage Status

coverage: 93.518% (+0.007%) from 93.511%
when pulling e7d3928 on standardize-controller-indexes
into bd075db on main.

@nimmolo nimmolo changed the title Query param simplificaitons: Move with_observations_for_project into with_observations Query param simplifications: Move for_project and for_species_list into main query classes Dec 17, 2024
@nimmolo nimmolo changed the title Query param simplifications: Move for_project and for_species_list into main query classes Query param simplifications: Move for_project into main query classes Dec 18, 2024
@nimmolo nimmolo marked this pull request as ready for review December 18, 2024 00:03
@nimmolo nimmolo requested a review from JoeCohen December 18, 2024 00:06
@nimmolo nimmolo requested a review from mo-nathan December 18, 2024 21:01
@nimmolo nimmolo changed the title Query param simplifications: Move for_project into main query classes Query param simplifications: Move more params into main query classes Dec 18, 2024
Copy link
Member

@JoeCohen JoeCohen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No visible problems when played around in the branch for > 1hr.

@nimmolo
Copy link
Contributor Author

nimmolo commented Dec 18, 2024

Appreciate all that testing, @JoeCohen

@nimmolo nimmolo merged commit 5d35379 into main Dec 18, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants